-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add check for external_emergency_stop_heartbeat_received_time to isDataReady #2155
fix: add check for external_emergency_stop_heartbeat_received_time to isDataReady #2155
Conversation
e4bea47
to
c8f2bb5
Compare
c8f2bb5
to
24c394c
Compare
Codecov ReportBase: 11.09% // Head: 11.08% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2155 +/- ##
==========================================
- Coverage 11.09% 11.08% -0.02%
==========================================
Files 1213 1213
Lines 86618 86732 +114
Branches 20787 20858 +71
==========================================
+ Hits 9612 9613 +1
- Misses 66847 66958 +111
- Partials 10159 10161 +2
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@s-azumi Could you tell me how you confirmed this pr? |
9588e6e
to
b59bb66
Compare
@h-ohta @TakaHoribe |
@s-azumi I'll wait PR for launch. |
b59bb66
to
8d9d08b
Compare
@h-ohta @TakaHoribe PRs for launch are here, please review with this. |
95c24a0
to
ccf3b8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@TakaHoribe Could you confirm README changes ?
ccf3b8e
to
715ac73
Compare
… isDataReady Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp>
Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp>
Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp>
1fc5e81
to
968ef51
Compare
… isDataReady (autowarefoundation#2155) * fix: add check for external_emergency_stop_heartbeat_received_time to isDataReady Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> * feat: add README about `use_external_emergency_stop` parameter Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> * fix: update README as recommended Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp>
… isDataReady (autowarefoundation#2155) (#188) fix: add check for external_emergency_stop_heartbeat_received_time to isDataReady (autowarefoundation#2155) * fix: add check for external_emergency_stop_heartbeat_received_time to isDataReady Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> * feat: add README about `use_external_emergency_stop` parameter Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> * fix: update README as recommended Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp>
… isDataReady (autowarefoundation#2155) * fix: add check for external_emergency_stop_heartbeat_received_time to isDataReady Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> * feat: add README about `use_external_emergency_stop` parameter Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> * fix: update README as recommended Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
… isDataReady (autowarefoundation#2155) * fix: add check for external_emergency_stop_heartbeat_received_time to isDataReady Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> * feat: add README about `use_external_emergency_stop` parameter Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> * fix: update README as recommended Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp>
… isDataReady (autowarefoundation#2155) * fix: add check for external_emergency_stop_heartbeat_received_time to isDataReady Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> * feat: add README about `use_external_emergency_stop` parameter Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> * fix: update README as recommended Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Description
The vehicle_cmd_gate node periodically checks two heartbeat topics: system emergency heartbeat and external emergency stop heartbeat.
However, in the initialization function (isDataReady) only checks for system emergency heartbeat.
So I`ll add a check for the external emergency stop heartbeat to the initialization function.
TierIV Internal Link
https://tier4.atlassian.net/browse/T4PB-21179
Tests performed
use_external_emergency_stop
argument in control.launch.py istrue
.external_emergency_stop_heartbeat_received_time_ is false
in the terminal.use_external_emergency_stop
isfalse
, then you can engage the vehicle on simulaotr./external/selected/heartbeat
topic(e.g. by rqt Message Publisher), then you can engage the vehicle.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.