fix(detected_object_validation): add utils to CMakeLists and fix include filename #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ude filename Signed-off-by: Shin-kyoto <shintaro.tomie@tier4.jp>
Codecov ReportBase: 10.76% // Head: 10.76% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2133 +/- ##
==========================================
- Coverage 10.76% 10.76% -0.01%
==========================================
Files 1182 1183 +1
Lines 84564 84569 +5
Branches 19829 19829
==========================================
Hits 9105 9105
- Misses 65959 65964 +5
Partials 9500 9500
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
miursh
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixs these issues.
src/utils.cppis not written in autoware.universe/perception/detected_object_validation/CMakeLists.txt, so src/utils.cpp is not built and runtime error occurs.#include <autoware_auto_perception_msgs/msg/ObjectClassification.hpp>should be#include <autoware_auto_perception_msgs/msg/object_classification.hpp>Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.