Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(signal_processing): fix unit test bug #1960

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 27, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

Related to #1959

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Comment on lines -36 to 37
void reset() { x_ = T{}; }
void reset() { x_ = {}; }
void reset(const T & x) { x_ = x; }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the same way as

void LowpassFilter1d::reset() { x_ = {}; }

@kenji-miyake
Copy link
Contributor

Thank you for your fixing.
Could I test CI before merging this PR?

@takayuki5168
Copy link
Contributor Author

@kenji-miyake Of course. I'm not in a hurry.

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 10.44% // Head: 10.34% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (4c739d6) compared to base (93cc9bd).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1960      +/-   ##
==========================================
- Coverage   10.44%   10.34%   -0.11%     
==========================================
  Files        1233     1234       +1     
  Lines       88034    88963     +929     
  Branches    20501    20508       +7     
==========================================
+ Hits         9197     9199       +2     
- Misses      69328    70249     +921     
- Partials     9509     9515       +6     
Flag Coverage Δ *Carryforward flag
differential 0.78% <0.00%> (?)
total 10.43% <0.00%> (ø) Carriedforward from 93cc9bd

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ssing/include/signal_processing/lowpass_filter.hpp 100.00% <ø> (ø)
...nal_processing/test/src/lowpass_filter_1d_test.cpp 35.71% <0.00%> (ø)
...signal_processing/test/src/lowpass_filter_test.cpp 25.58% <0.00%> (-0.14%) ⬇️
planning/obstacle_stop_planner/src/node.cpp 0.00% <0.00%> (ø)
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
...lanning/obstacle_stop_planner/src/debug_marker.cpp 0.00% <0.00%> (ø)
...ning/obstacle_cruise_planner/src/polygon_utils.cpp 0.00% <0.00%> (ø)
...e_planner/include/obstacle_cruise_planner/node.hpp 0.00% <0.00%> (ø)
...ner/include/obstacle_stop_planner/debug_marker.hpp 0.00% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ambroise-arm
Copy link
Contributor

LGTM, tested locally on arm

@kenji-miyake
Copy link
Contributor

@ambroise-arm Could you review autowarefoundation/autoware-github-actions#185 before merging this PR, please? 🙏

@takayuki5168
Copy link
Contributor Author

@kenji-miyake I tested locally with RelWithDebInfo, the issue did not occur.

Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I was able to reproduce the issue in #1965, it's okay to merge this PR.

@kenji-miyake kenji-miyake changed the title fix(signal_processing): unit test bug test(signal_processing): unit test bug Sep 29, 2022
@kenji-miyake kenji-miyake changed the title test(signal_processing): unit test bug test(signal_processing): fix unit test bug Sep 29, 2022
@kenji-miyake
Copy link
Contributor

@takayuki5168 Since this PR won't fix any feature, I've changed the title from fix to test.

@takayuki5168
Copy link
Contributor Author

takayuki5168 commented Sep 29, 2022

@kenji-miyake
Okay, but in my understanding, this PR resolved the issue that unit test failed on Arm. Even in this case, Should we set test instead of fix?
#1959

@takayuki5168 takayuki5168 merged commit 248295e into autowarefoundation:main Sep 29, 2022
@takayuki5168 takayuki5168 deleted the fix/twist-lpf-bug branch September 29, 2022 00:56
@kenji-miyake
Copy link
Contributor

@takayuki5168 Uh, sorry. I overlooked the first file. 🥺

kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Sep 29, 2022
fix(signal_processing): unit test bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
fix(signal_processing): unit test bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
fix(signal_processing): unit test bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
fix(signal_processing): unit test bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants