-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(signal_processing): fix unit test bug #1960
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
void reset() { x_ = T{}; } | ||
void reset() { x_ = {}; } | ||
void reset(const T & x) { x_ = x; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the same way as
void LowpassFilter1d::reset() { x_ = {}; } |
Thank you for your fixing. |
@kenji-miyake Of course. I'm not in a hurry. |
Codecov ReportBase: 10.44% // Head: 10.34% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1960 +/- ##
==========================================
- Coverage 10.44% 10.34% -0.11%
==========================================
Files 1233 1234 +1
Lines 88034 88963 +929
Branches 20501 20508 +7
==========================================
+ Hits 9197 9199 +2
- Misses 69328 70249 +921
- Partials 9509 9515 +6
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
LGTM, tested locally on arm |
@ambroise-arm Could you review autowarefoundation/autoware-github-actions#185 before merging this PR, please? 🙏 |
@kenji-miyake I tested locally with RelWithDebInfo, the issue did not occur. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I was able to reproduce the issue in #1965, it's okay to merge this PR.
@takayuki5168 Since this PR won't fix any feature, I've changed the title from |
@kenji-miyake |
@takayuki5168 Uh, sorry. I overlooked the first file. 🥺 |
fix(signal_processing): unit test bug Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
fix(signal_processing): unit test bug Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
fix(signal_processing): unit test bug Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
fix(signal_processing): unit test bug Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka takayuki5168@gmail.com
Description
Related to #1959
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.