Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build-and-test): add cmake-build-type #1965

Closed
wants to merge 4 commits into from
Closed

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented Sep 27, 2022

Description

Add the debug build to the scheduled test in order to test in more detail.

Related:

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kenji-miyake
Copy link
Contributor Author

kenji-miyake commented Sep 27, 2022

@kenji-miyake
Copy link
Contributor Author

Since it uses 8 jobs, it might be better to create another workflow that only runs daily. (Doesn't run after a PR is merged.)
image

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 11.13% // Head: 10.27% // Decreases project coverage by -0.86% ⚠️

Coverage data is based on head (b389f8e) compared to base (444e56b).
Patch has no changes to coverable lines.

❗ Current head b389f8e differs from pull request most recent head 52b9e88. Consider uploading reports for the commit 52b9e88 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1965      +/-   ##
==========================================
- Coverage   11.13%   10.27%   -0.87%     
==========================================
  Files        1203     1158      -45     
  Lines       86271    82148    -4123     
  Branches    20832    19115    -1717     
==========================================
- Hits         9610     8440    -1170     
+ Misses      66497    64565    -1932     
+ Partials    10164     9143    -1021     
Flag Coverage Δ
total 10.25% <ø> (-0.86%) ⬇️
Impacted Files Coverage Δ
vehicle/raw_vehicle_cmd_converter/src/pid.cpp 0.00% <0.00%> (-85.72%) ⬇️
...lude/behavior_path_planner/turn_signal_decider.hpp 0.00% <0.00%> (-85.72%) ⬇️
...onverter/include/raw_vehicle_cmd_converter/pid.hpp 0.00% <0.00%> (-66.67%) ⬇️
...lude/freespace_planning_algorithms/reeds_shepp.hpp 50.00% <0.00%> (-50.00%) ⬇️
.../freespace_planning_algorithms/src/reeds_shepp.cpp 55.51% <0.00%> (-38.97%) ⬇️
.../behavior_path_planner/src/turn_signal_decider.cpp 0.00% <0.00%> (-35.94%) ⬇️
...ehicle/raw_vehicle_cmd_converter/src/brake_map.cpp 17.85% <0.00%> (-27.31%) ⬇️
...eespace_planning_algorithms/abstract_algorithm.hpp 44.44% <0.00%> (-25.56%) ⬇️
...ehicle/raw_vehicle_cmd_converter/src/accel_map.cpp 19.23% <0.00%> (-20.06%) ⬇️
...hicle/raw_vehicle_cmd_converter/src/csv_loader.cpp 53.84% <0.00%> (-11.07%) ⬇️
... and 303 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kenji-miyake
Copy link
Contributor Author

kenji-miyake commented Sep 28, 2022

There isn't enough storage in GitHub-hosted runners.
https://github.com/autowarefoundation/autoware.universe/actions/runs/3137769767
image

@kenji-miyake
Copy link
Contributor Author

kenji-miyake commented Sep 29, 2022

@kenji-miyake kenji-miyake marked this pull request as ready for review November 9, 2022 15:11
@kenji-miyake kenji-miyake marked this pull request as draft November 9, 2022 15:11
Kenji Miyake added 4 commits November 10, 2022 00:11
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@stale
Copy link

stale bot commented Jan 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jan 15, 2023
@kenji-miyake kenji-miyake deleted the add-debug-build branch July 2, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant