Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lidar_centerpoint): change default threshold params #1874

Merged

Conversation

yukke42
Copy link
Contributor

@yukke42 yukke42 commented Sep 15, 2022

Signed-off-by: yukke42 yusuke.muramatsu@tier4.jp

Description

Change the default params for these reason

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
@yukke42 yukke42 requested a review from yukkysaito as a code owner September 15, 2022 08:25
@yukke42 yukke42 requested a review from miursh September 15, 2022 08:25
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 10.35% // Head: 10.43% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (337c616) compared to base (7e2370d).
Patch coverage: 20.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1874      +/-   ##
==========================================
+ Coverage   10.35%   10.43%   +0.08%     
==========================================
  Files        1159     1232      +73     
  Lines       76241    87941   +11700     
  Branches    18730    20429    +1699     
==========================================
+ Hits         7895     9178    +1283     
- Misses      59481    69304    +9823     
- Partials     8865     9459     +594     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.42% <20.00%> (+0.06%) ⬆️ Carriedforward from 31e63b7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...tion_utils/test/src/trajectory/test_trajectory.cpp 26.26% <ø> (+3.75%) ⬆️
...t/include/lidar_centerpoint/centerpoint_config.hpp 0.00% <ø> (ø)
perception/lidar_centerpoint/src/node.cpp 0.00% <0.00%> (ø)
...ning/obstacle_cruise_planner/src/polygon_utils.cpp 0.00% <ø> (ø)
...ils/include/motion_utils/trajectory/trajectory.hpp 78.81% <33.33%> (+0.26%) ⬆️
...lude/freespace_planning_algorithms/reeds_shepp.hpp 50.00% <0.00%> (-50.00%) ⬇️
...tic_evaluator/include/kinematic_evaluator/stat.hpp 62.50% <0.00%> (-19.32%) ⬇️
..._evaluator/include/localization_evaluator/stat.hpp 56.25% <0.00%> (-16.48%) ⬇️
.../src/vehicle/test_vehicle_state_checker_helper.hpp 70.58% <0.00%> (-9.42%) ⬇️
planning/behavior_path_planner/test/input.cpp 60.00% <0.00%> (-7.86%) ⬇️
... and 856 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@miursh
Copy link
Contributor

miursh commented Sep 15, 2022

I confirmed the parameters have surely changed.

$ ros2  param dump --print /perception/object_recognition/detection/centerpoint/lidar_centerpoint
/perception/object_recognition/detection/centerpoint/lidar_centerpoint:
  ros__parameters:
    circle_nms_dist_threshold: 1.5
    class_names:
    - CAR
    - PEDESTRIAN
    - BICYCLE
    densification_num_past_frames: 1
    densification_world_frame_id: map
    downsample_factor: 2
    encoder_engine_path: /media/miura/WDB4T/workspace/autoware/autoware/install/lidar_centerpoint/share/lidar_centerpoint/data/pts_voxel_encoder_centerpoint_tiny.engine
    encoder_in_feature_size: 9
    encoder_onnx_path: /media/miura/WDB4T/workspace/autoware/autoware/install/lidar_centerpoint/share/lidar_centerpoint/data/pts_voxel_encoder_centerpoint_tiny.onnx
    has_twist: false
    head_engine_path: /media/miura/WDB4T/workspace/autoware/autoware/install/lidar_centerpoint/share/lidar_centerpoint/data/pts_backbone_neck_head_centerpoint_tiny.engine
    head_onnx_path: /media/miura/WDB4T/workspace/autoware/autoware/install/lidar_centerpoint/share/lidar_centerpoint/data/pts_backbone_neck_head_centerpoint_tiny.onnx
    max_voxel_size: 40000
    point_cloud_range:
    - -89.6
    - -89.6
    - -3.0
    - 89.6
    - 89.6
    - 5.0
    point_feature_size: 4
    qos_overrides:
      /clock:
        subscription:
          depth: 1
          durability: volatile
          history: keep_last
          reliability: best_effort
      /parameter_events:
        publisher:
          depth: 1000
          durability: volatile
          history: keep_last
          reliability: reliable
    rename_car_to_truck_and_bus: true
    score_threshold: 0.35
    trt_precision: fp16
    use_sim_time: true
    voxel_size:
    - 0.32
    - 0.32
    - 8.0
    yaw_norm_threshold: 0.0

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukke42 yukke42 enabled auto-merge (squash) September 15, 2022 09:44
@yukke42 yukke42 added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Sep 15, 2022
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukke42 yukke42 merged commit 7c9333f into autowarefoundation:main Sep 15, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…efoundation#1874)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
@yukke42 yukke42 deleted the change-centerpoint-default-params branch September 30, 2022 08:04
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…efoundation#1874)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…efoundation#1874)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
0x126 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 17, 2022
…efoundation#1874)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…efoundation#1874)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants