Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_utils): generalize overlap functions #1871

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Sep 15, 2022

Signed-off-by: yutaka purewater0901@gmail.com

Description

I use a template to generalize the removeOverlap function in motion_utils so that now we can use the function outside of the motion_utils. I also add unit tests for the function.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 enabled auto-merge (squash) September 15, 2022 04:59
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 10.43% // Head: 10.62% // Increases project coverage by +0.18% 🎉

Coverage data is based on head (05d229d) compared to base (d714775).
Patch coverage: 23.68% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1871      +/-   ##
==========================================
+ Coverage   10.43%   10.62%   +0.18%     
==========================================
  Files        1232     1232              
  Lines       87931    88450     +519     
  Branches    20411    20785     +374     
==========================================
+ Hits         9174     9395     +221     
- Misses      69297    69504     +207     
- Partials     9460     9551      +91     
Flag Coverage Δ *Carryforward flag
differential 10.70% <24.00%> (?)
total 10.41% <33.33%> (ø) Carriedforward from d714775

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ning/obstacle_cruise_planner/src/polygon_utils.cpp 0.00% <0.00%> (ø)
...tion_utils/test/src/trajectory/test_trajectory.cpp 26.01% <18.46%> (-0.25%) ⬇️
...ils/include/motion_utils/trajectory/trajectory.hpp 81.01% <60.00%> (+2.19%) ⬆️
...ity_planner/src/scene_module/crosswalk/manager.cpp 0.00% <0.00%> (ø)
...ty_planner/src/scene_module/blind_spot/manager.cpp 0.00% <0.00%> (ø)
..._planner/src/scene_module/intersection/manager.cpp 0.00% <0.00%> (ø)
...planner/src/scene_module/traffic_light/manager.cpp 0.00% <0.00%> (ø)
...lanner/src/scene_module/detection_area/manager.cpp 0.00% <0.00%> (ø)
...nner/src/scene_module/no_stopping_area/manager.cpp 0.00% <0.00%> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@purewater0901 purewater0901 merged commit 23e261c into autowarefoundation:main Sep 15, 2022
@purewater0901 purewater0901 deleted the feat/clean-overlap-code branch September 15, 2022 09:59
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…1871)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…1871)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…1871)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 17, 2022
…1871)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 17, 2022
…1871)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 17, 2022
…1871)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 17, 2022
…1871)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 17, 2022
…1871)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 18, 2022
…1871)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…1871)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 27, 2022
…1871)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 10, 2022
…1871)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 30, 2022
…1871)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants