Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): use debug_marker of interface for pull_over #1843

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 12, 2022

Signed-off-by: kosuke55 kosuke.tnp@gmail.com

Description

use debug_marker of interface /planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/debug/pullover for pull_over.

Screenshot from 2022-09-12 22-01-16

and fix typos.

Related links

#1711

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55
Copy link
Contributor Author

kosuke55 commented Sep 12, 2022

  • remove old rviz configurations.

@kosuke55 kosuke55 changed the title fefactor(behavior_path_planner): use debug_marker of interface for pull_over refactor(behavior_path_planner): use debug_marker of interface for pull_over Sep 12, 2022
…ll_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the refactor/pull_over_debug_marker branch from c604533 to 44c78d0 Compare September 12, 2022 13:26
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #1843 (452cc26) into main (25c30f2) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1843      +/-   ##
==========================================
- Coverage   10.43%   10.38%   -0.05%     
==========================================
  Files        1221     1221              
  Lines       87777    88221     +444     
  Branches    20518    20812     +294     
==========================================
+ Hits         9159     9163       +4     
- Misses      69139    69561     +422     
- Partials     9479     9497      +18     
Flag Coverage Δ *Carryforward flag
differential 1.28% <0.00%> (?)
total 10.41% <0.00%> (ø) Carriedforward from 25c30f2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/pull_over/pull_over_module.hpp 0.00% <ø> (ø)
.../scene_module/utils/geometric_parallel_parking.hpp 0.00% <0.00%> (ø)
...lanner/include/behavior_path_planner/utilities.hpp 23.52% <ø> (-1.48%) ⬇️
...or_path_planner/src/behavior_path_planner_node.cpp 0.43% <0.00%> (+0.21%) ⬆️
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)
...r_path_planner/src/scene_module/pull_over/util.cpp 0.00% <0.00%> (ø)
.../scene_module/utils/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)
planning/route_handler/src/route_handler.cpp 0.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kosuke55 kosuke55 merged commit d58268d into autowarefoundation:main Sep 12, 2022
@kosuke55 kosuke55 deleted the refactor/pull_over_debug_marker branch September 12, 2022 14:23
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…ll_over (autowarefoundation#1843)

* refactor(behavior_path_planner): use debug_marker of interface for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typos

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ll_over (autowarefoundation#1843)

* refactor(behavior_path_planner): use debug_marker of interface for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typos

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ll_over (autowarefoundation#1843)

* refactor(behavior_path_planner): use debug_marker of interface for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typos

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 17, 2022
…ll_over (autowarefoundation#1843)

* refactor(behavior_path_planner): use debug_marker of interface for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typos

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 18, 2022
…ll_over (autowarefoundation#1843)

* refactor(behavior_path_planner): use debug_marker of interface for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typos

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…ll_over (autowarefoundation#1843)

* refactor(behavior_path_planner): use debug_marker of interface for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typos

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 10, 2022
…ll_over (autowarefoundation#1843)

* refactor(behavior_path_planner): use debug_marker of interface for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typos

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 30, 2022
…ll_over (autowarefoundation#1843)

* refactor(behavior_path_planner): use debug_marker of interface for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typos

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants