Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat(rviz): add behavior path debug markers #462

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Sep 1, 2022

Signed-off-by: satoshi-ota satoshi.ota928@gmail.com

PR Type

  • Improvement

Related Links

Description

  • add debug markers of following behavior path modules

    • avoidance
    • lane change
    • lane following
    • pull over
    • pull out
    • side shift
  • hide debug markers as default

Review Procedure

Screenshot from 2022-09-01 13-15-15

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55
Copy link
Contributor

kosuke55 commented Sep 1, 2022

@satoshi-ota satoshi-ota merged commit 21a4dbe into awf-latest Sep 1, 2022
@satoshi-ota satoshi-ota deleted the feat/add-behavior-path-debug-markers branch September 1, 2022 04:24
satoshi-ota added a commit that referenced this pull request Sep 7, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@kosuke55
Copy link
Contributor

@satoshi-ota
Could you please update awf's one https://github.com/autowarefoundation/autoware_launch/blob/main/autoware_launch/rviz/autoware.rviz ?

@satoshi-ota
Copy link
Contributor Author

@kosuke55 I created PR in awf/autoware_launch. autowarefoundation/autoware_launch#85

kosuke55 added a commit that referenced this pull request Jan 17, 2023
* feat(rviz): add behavior path debug markers (#441)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(rviz): add 2D dummy bus button as default (#453)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(rviz): add behavior path debug markers (#462)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(rviz): remove old pull over marker

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
takayuki5168 pushed a commit that referenced this pull request Jan 21, 2023
* move simple_planning_simulator

* add simulation arg to logging_simulator.launch

* delete unused argument

* add arguments for logging simulation

* change default value

* update README

* add default value to simulator arg

* restore vehicle_simulation arg
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants