Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(joy_controller): joystick keymap fix in readme #1834

Merged
merged 5 commits into from
Sep 14, 2022
Merged

docs(joy_controller): joystick keymap fix in readme #1834

merged 5 commits into from
Sep 14, 2022

Conversation

sfukuta
Copy link
Contributor

@sfukuta sfukuta commented Sep 12, 2022 •
edited
Loading

Description

Convert the joystick key map in the readme from P65 to DS4.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

kenji-miyake
kenji-miyake suggested changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change the title from fix to docs because this PR won't change any behavior.

control/joy_controller/README.md Show resolved Hide resolved
@kenji-miyake kenji-miyake changed the title fix(joy_controller): joystick keymap fix in readme docs(joy_controller): joystick keymap fix in readme Sep 12, 2022
@kenji-miyake
Copy link
Contributor

Also, please read the guidelines and check off the checkboxes.
image

@kenji-miyake
Copy link
Contributor

Also, the DCO check has failed.
image

Please confirm the CI checks section and fix the error.

Shigekazu Fukuta and others added 3 commits September 13, 2022 10:17
fix(joy_controller): joystick keymap fix in readme
ff8c7b7 
Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
@pre-commit-ci
ci(pre-commit): autofix
3c57644 
Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
revert joystick keymap in P65
cd17ada 
Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
@sfukuta sfukuta force-pushed the feat/fix-joy_controller-readme branch from c6fc956 to cd17ada Compare September 13, 2022 01:18
@sfukuta
Copy link
Contributor Author

sfukuta commented Sep 13, 2022 •
edited
Loading

・Guideline checked the checkboxes.
・DCO check has successful.

kenji-miyake
kenji-miyake reviewed Sep 13, 2022
View reviewed changes
control/joy_controller/README.md Outdated
Comment on lines 68 to 70
| Acceleration | R2 |
| -------------------- | ---------------------------------------- |
| Brake | □ or Right Stick Up Down or Left Trigger |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is correct? 🤔

Suggested change
| Acceleration | R2 |
| -------------------- | ---------------------------------------- |
| Brake | □ or Right Stick Up Down or Left Trigger |
| Action | Button |
| -------------------- | ---------------------------------------- |
| Acceleration | R2, ×, or Right Stick Up |
| Brake | L2, □, or Right Stick Down |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also fix the table header of the P65's keymap?
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Fixed joystick keymap header title and DS4 keymaps
215625a 
Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
kenji-miyake
kenji-miyake approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kenji-miyake kenji-miyake enabled auto-merge (squash) September 13, 2022 02:31
@sfukuta
Copy link
Contributor Author

sfukuta commented Sep 14, 2022

@kenji-miyake Please workflow review and run.
workflow

@sfukuta
Copy link
Contributor Author

sfukuta commented Sep 14, 2022

Thank you!

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 10.45% // Head: 10.45% // No change to project coverage 👍

Coverage data is based on head (46c5866) compared to base (edfe616).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1834   +/-   ##
=======================================
  Coverage   10.45%   10.45%           
=======================================
  Files        1220     1220           
  Lines       87626    87626           
  Branches    20523    20523           
=======================================
  Hits         9165     9165           
  Misses      68989    68989           
  Partials     9472     9472
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.44% <ø> (ø) Carriedforward from edfe616

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kenji-miyake kenji-miyake merged commit 6db9e79 into autowarefoundation:main Sep 14, 2022
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Sep 15, 2022
Merged
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
@sfukuta @pre-commit-ci @boyali
docs(joy_controller): joystick keymap fix in readme (autowarefoundati…
84d346c 
…on#1834)

* fix(joy_controller): joystick keymap fix in readme

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* ci(pre-commit): autofix

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* revert joystick keymap in P65

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* Fixed joystick keymap header title and DS4 keymaps

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
@sfukuta @pre-commit-ci @boyali
docs(joy_controller): joystick keymap fix in readme (autowarefoundati…
816679a 
…on#1834)

* fix(joy_controller): joystick keymap fix in readme

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* ci(pre-commit): autofix

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* revert joystick keymap in P65

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* Fixed joystick keymap header title and DS4 keymaps

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
@sfukuta @pre-commit-ci @boyali
docs(joy_controller): joystick keymap fix in readme (autowarefoundati…
5ef1139 
…on#1834)

* fix(joy_controller): joystick keymap fix in readme

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* ci(pre-commit): autofix

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* revert joystick keymap in P65

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* Fixed joystick keymap header title and DS4 keymaps

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
@sfukuta @pre-commit-ci @boyali
docs(joy_controller): joystick keymap fix in readme (autowarefoundati…
92fb52d 
…on#1834)

* fix(joy_controller): joystick keymap fix in readme

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* ci(pre-commit): autofix

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* revert joystick keymap in P65

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

* Fixed joystick keymap header title and DS4 keymaps

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>

Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenji-miyake kenji-miyake kenji-miyake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfukuta @kenji-miyake