Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_avoidance_planner): fix can be applied to the first trajectory point #1775

Merged
merged 7 commits into from
Sep 15, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 4, 2022

Description

  • organized documentation
  • implemented the fixing points algorithm to fix only the first trajectory point
    • By default, fixing points around the ego is used. So there is no behavior change

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 added the type:documentation Creating or refining documentation. (auto-assigned) label Sep 4, 2022
@codecov
Copy link

codecov bot commented Sep 4, 2022

Codecov Report

Base: 10.42% // Head: 10.34% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (d241a8c) compared to base (19ce83b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1775      +/-   ##
==========================================
- Coverage   10.42%   10.34%   -0.09%     
==========================================
  Files        1226     1226              
  Lines       87945    88649     +704     
  Branches    20455    20455              
==========================================
  Hits         9171     9171              
- Misses      69270    69974     +704     
  Partials     9504     9504              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.41% <0.00%> (ø) Carriedforward from 19ce83b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...anner/include/scene_module/traffic_light/scene.hpp 0.00% <ø> (ø)
...y_planner/src/scene_module/traffic_light/scene.cpp 0.00% <0.00%> (ø)
...lude/obstacle_avoidance_planner/common_structs.hpp 0.00% <ø> (ø)
...anner/include/obstacle_avoidance_planner/utils.hpp 0.00% <0.00%> (ø)
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 0.00% <0.00%> (ø)
planning/obstacle_avoidance_planner/src/node.cpp 0.00% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 changed the title Fix/mpt kaizen2 feat(obstacle_avoidance_planner): fix can be applied to the first trajectory point Sep 9, 2022
@takayuki5168 takayuki5168 marked this pull request as ready for review September 9, 2022 16:19
@kosuke55
Copy link
Contributor

pull_over and pull_out works fine with this PR

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168
Copy link
Contributor Author

@TakaHoribe Give me LGTM!

@takayuki5168 takayuki5168 merged commit 03b4741 into autowarefoundation:main Sep 15, 2022
@takayuki5168 takayuki5168 deleted the fix/mpt-kaizen2 branch September 15, 2022 12:40
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…jectory point (autowarefoundation#1775)

* add bicycle model collision avoidance and single fixed point

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor manual warm start

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add calculation cost plotter

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update params

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…jectory point (autowarefoundation#1775)

* add bicycle model collision avoidance and single fixed point

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor manual warm start

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add calculation cost plotter

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update params

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…jectory point (autowarefoundation#1775)

* add bicycle model collision avoidance and single fixed point

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor manual warm start

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add calculation cost plotter

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update params

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…jectory point (autowarefoundation#1775)

* add bicycle model collision avoidance and single fixed point

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor manual warm start

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add calculation cost plotter

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update params

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants