-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): avoidance drivable area in intersection #1707
fix(behavior_path_planner): avoidance drivable area in intersection #1707
Conversation
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## main #1707 +/- ##
==========================================
- Coverage 10.05% 10.01% -0.05%
==========================================
Files 1197 1197
Lines 86337 86703 +366
Branches 19867 20162 +295
==========================================
+ Hits 8685 8686 +1
- Misses 68447 68788 +341
- Partials 9205 9229 +24
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…1707) * fix(behavior_path_planner): avoidance drivable area in intersection Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * slight refactor since shared linestring lanelet lambda is not reused Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * use current_lanes instead for the for loop Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…ier4#1707) * fix(behavior_path_planner): avoidance drivable area in intersection Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * slight refactor since shared linestring lanelet lambda is not reused Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * use current_lanes instead for the for loop Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…ier4#1707) * fix(behavior_path_planner): avoidance drivable area in intersection Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * slight refactor since shared linestring lanelet lambda is not reused Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * use current_lanes instead for the for loop Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…ier4#1707) * fix(behavior_path_planner): avoidance drivable area in intersection Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * slight refactor since shared linestring lanelet lambda is not reused Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * use current_lanes instead for the for loop Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…utowarefoundation#1707) * fix(behavior_path_planner): avoidance drivable area in intersection Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * slight refactor since shared linestring lanelet lambda is not reused Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * use current_lanes instead for the for loop Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…ier4#1707) * fix(behavior_path_planner): avoidance drivable area in intersection Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * slight refactor since shared linestring lanelet lambda is not reused Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * use current_lanes instead for the for loop Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…nvalid_detection_result/v0.29.0-1 fix: overwrite invalid detection result/v0.29.0 1
Signed-off-by: Muhammad Zulfaqar Azmi zulfaqar.azmi@tier4.jp
Description
Due to the effects of #1688, the drivable area is not extended in the following case
This PR aims to fix the bug
Related links
#1702
Tests performed
In psim, place the object in the location after intersection with two lanes. Drivable area should be expanded.
Test 1
2022-08-26-17-26-35.mp4
Test 2
2022-08-26-17-27-28.mp4
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.