Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): avoidance drivable area in intersection #1707

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Aug 26, 2022

Signed-off-by: Muhammad Zulfaqar Azmi zulfaqar.azmi@tier4.jp

Description

Due to the effects of #1688, the drivable area is not extended in the following case

image

This PR aims to fix the bug

Related links

#1702

Tests performed

In psim, place the object in the location after intersection with two lanes. Drivable area should be expanded.

Test 1

2022-08-26-17-26-35.mp4

Test 2

2022-08-26-17-27-28.mp4

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image
image

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #1707 (9b5aa2c) into main (2712884) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1707      +/-   ##
==========================================
- Coverage   10.05%   10.01%   -0.05%     
==========================================
  Files        1197     1197              
  Lines       86337    86703     +366     
  Branches    19867    20162     +295     
==========================================
+ Hits         8685     8686       +1     
- Misses      68447    68788     +341     
- Partials     9205     9229      +24     
Flag Coverage Δ *Carryforward flag
differential 0.79% <0.00%> (?)
total 10.04% <0.00%> (ø) Carriedforward from 0a64c03

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.35% <0.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 32645a5 into autowarefoundation:main Aug 26, 2022
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the fix/drivable-area-expansion-in-intersection branch August 26, 2022 13:19
taikitanaka3 referenced this pull request in tier4/autoware.universe Aug 29, 2022
…1707)

* fix(behavior_path_planner): avoidance drivable area in intersection

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* slight refactor since shared linestring lanelet lambda is not reused

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* use current_lanes instead for the for loop

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…ier4#1707)

* fix(behavior_path_planner): avoidance drivable area in intersection

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* slight refactor since shared linestring lanelet lambda is not reused

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* use current_lanes instead for the for loop

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ier4#1707)

* fix(behavior_path_planner): avoidance drivable area in intersection

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* slight refactor since shared linestring lanelet lambda is not reused

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* use current_lanes instead for the for loop

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ier4#1707)

* fix(behavior_path_planner): avoidance drivable area in intersection

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* slight refactor since shared linestring lanelet lambda is not reused

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* use current_lanes instead for the for loop

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…utowarefoundation#1707)

* fix(behavior_path_planner): avoidance drivable area in intersection

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* slight refactor since shared linestring lanelet lambda is not reused

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* use current_lanes instead for the for loop

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…ier4#1707)

* fix(behavior_path_planner): avoidance drivable area in intersection

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* slight refactor since shared linestring lanelet lambda is not reused

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* use current_lanes instead for the for loop

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
saka1-s added a commit to saka1-s/autoware.universe that referenced this pull request Dec 22, 2024
…nvalid_detection_result/v0.29.0-1

fix: overwrite invalid detection result/v0.29.0 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants