fix: overwrite invalid detection result for gen1 #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
saka1-s
requested review from
satoshi-ota,
miursh and
tzhong518
as code owners
saka1-s
changed the title
|
| { | ||
| // check occlusion, backlight(shape is unknown) and no detection(shape is circle) | ||
| if ( | ||
| signal.elements.front().color == TrafficSignalElement::UNKNOWN && |
There was a problem hiding this comment.
Maybe || is better than &&, I'm not sure.
XiaoyuWang0601
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
same as #1705
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.