Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_crosswalk_traffic_light_estimator): overwrite invalid detection result #1705

Conversation

MasatoSaeki
Copy link

Description

This PR enables to overwrite invalid detection result made by ML.
Concretely, overwrite if below condition:

  • undetection -> color: unknown, shape: circle, confidence=0.0
  • backlight -> color: unknown, shape: unknown, confidence=0.0
  • occlusion -> color: unknown, shape: unknown, confidence=0.0

Related links

Parent Issue:

  • Link

How was this PR tested?

I have checked topic contents which is pedestrian signals on logging simulator(pilot-auto and pilot-auto.x2) w/ planning and put gorl pose in order to get route topic.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

MasatoSaeki and others added 2 commits December 17, 2024 11:25
@MasatoSaeki MasatoSaeki marked this pull request as ready for review December 17, 2024 04:04
@MasatoSaeki MasatoSaeki requested a review from YoshiRi December 17, 2024 04:04
Copy link

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi merged commit 2934293 into beta/x2_gen2/v0.29.0 Dec 17, 2024
24 of 25 checks passed
@YoshiRi YoshiRi deleted the tmp/beta/x2_gen2/v0.29.0/overwrite_invalid_detection_result branch December 17, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants