Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnss_poser): solve gnss_ins_orientation parameter name error #1693

Conversation

meliketanrikulu
Copy link
Contributor

@meliketanrikulu meliketanrikulu commented Aug 25, 2022

Signed-off-by: melike tanrikulu melike@leodrive.ai

Description

It was opened to solve the problem that the gnss_ins_orientation parameter in the launch in the gnss_poser package and the parameter names in the cpp do not match.
Related launch file : https://github.com/autowarefoundation/autoware.universe/blob/main/sensing/gnss_poser/launch/gnss_poser.launch.xml

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: melike tanrikulu <melike@leodrive.ai>
@meliketanrikulu meliketanrikulu self-assigned this Aug 25, 2022
Signed-off-by: melike tanrikulu <melike@leodrive.ai>
@meliketanrikulu meliketanrikulu changed the title fix(gnss_poser): change gnss_ins_orientation parameter name fix(gnss_poser): solve gnss_ins_orientation parameter name error Aug 25, 2022
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1693 (a4bcd47) into main (25ba37d) will decrease coverage by 0.35%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1693      +/-   ##
==========================================
- Coverage   11.07%   10.72%   -0.36%     
==========================================
  Files        1037     1103      +66     
  Lines       75913    78394    +2481     
  Branches    18619    18649      +30     
==========================================
  Hits         8409     8409              
- Misses      58723    61071    +2348     
- Partials     8781     8914     +133     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.71% <0.00%> (-0.36%) ⬇️ Carriedforward from 0f34c05

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
sensing/gnss_poser/src/gnss_poser_core.cpp 0.00% <0.00%> (ø)
common/osqp_interface/src/osqp_interface.cpp 34.35% <0.00%> (ø)
planning/route_handler/src/route_handler.cpp 0.00% <0.00%> (ø)
planning/rtc_interface/src/rtc_interface.cpp 0.00% <0.00%> (ø)
control/trajectory_follower/src/mpc_utils.cpp 58.25% <0.00%> (ø)
planning/behavior_velocity_planner/src/node.cpp 0.43% <0.00%> (ø)
common/motion_utils/src/marker/marker_helper.cpp 0.00% <0.00%> (ø)
control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 0.25% <0.00%> (ø)
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
...nning/behavior_path_planner/src/path_utilities.cpp 0.00% <0.00%> (ø)
... and 154 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cyn-liu
Copy link
Contributor

cyn-liu commented Aug 25, 2022

hello, I have a question, why don't modify the parameter (use_ublox_receiver) in the gnss.launch.xml to (use_gnss_ins_orientation) .

@meliketanrikulu
Copy link
Contributor Author

meliketanrikulu commented Aug 25, 2022

hello, I have a question, why don't modify the parameter (use_ublox_receiver) in the gnss.launch.xml to (use_gnss_ins_orientation) .

Hello @cyn-liu . I have a PR related this. Its waiting. Here Sorry for the delay.

@YamatoAndo YamatoAndo added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Aug 26, 2022
@xmfcx xmfcx merged commit 9708c26 into autowarefoundation:main Sep 20, 2022
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants