-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gnss_poser): solve gnss_ins_orientation parameter name error #1693
fix(gnss_poser): solve gnss_ins_orientation parameter name error #1693
Conversation
Signed-off-by: melike tanrikulu <melike@leodrive.ai>
Signed-off-by: melike tanrikulu <melike@leodrive.ai>
Codecov Report
@@ Coverage Diff @@
## main #1693 +/- ##
==========================================
- Coverage 11.07% 10.72% -0.36%
==========================================
Files 1037 1103 +66
Lines 75913 78394 +2481
Branches 18619 18649 +30
==========================================
Hits 8409 8409
- Misses 58723 61071 +2348
- Partials 8781 8914 +133
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hello, I have a question, why don't modify the parameter (use_ublox_receiver) in the gnss.launch.xml to (use_gnss_ins_orientation) . |
Hello @cyn-liu . I have a PR related this. Its waiting. Here Sorry for the delay. |
…r4#1693) Signed-off-by: melike tanrikulu <melike@leodrive.ai>
…r4#1693) Signed-off-by: melike tanrikulu <melike@leodrive.ai>
…r4#1693) Signed-off-by: melike tanrikulu <melike@leodrive.ai>
…r4#1693) Signed-off-by: melike tanrikulu <melike@leodrive.ai>
Signed-off-by: melike tanrikulu melike@leodrive.ai
Description
It was opened to solve the problem that the gnss_ins_orientation parameter in the launch in the gnss_poser package and the parameter names in the cpp do not match.
Related launch file : https://github.com/autowarefoundation/autoware.universe/blob/main/sensing/gnss_poser/launch/gnss_poser.launch.xml
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.