Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(occlusion_spot): remove unused functions and refactor utils #1628

Merged
merged 2 commits into from
Aug 21, 2022

Conversation

taikitanaka3
Copy link
Contributor

Description

  • refactor change

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #1628 (23960d8) into main (9ef82dc) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1628      +/-   ##
==========================================
+ Coverage   10.78%   10.80%   +0.02%     
==========================================
  Files        1109     1109              
  Lines       78426    78831     +405     
  Branches    18521    18769     +248     
==========================================
+ Hits         8457     8517      +60     
- Misses      61114    61438     +324     
- Partials     8855     8876      +21     
Flag Coverage Δ *Carryforward flag
differential 4.23% <0.00%> (?)
total 10.76% <0.00%> (ø) Carriedforward from 096c395

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/scene_module/occlusion_spot/grid_utils.hpp 0.00% <ø> (ø)
...ene_module/occlusion_spot/occlusion_spot_utils.hpp 57.14% <ø> (ø)
...ner/src/scene_module/occlusion_spot/grid_utils.cpp 0.00% <ø> (ø)
...ene_module/occlusion_spot/occlusion_spot_utils.cpp 13.11% <ø> (+3.11%) ⬆️
..._module/occlusion_spot/risk_predictive_braking.cpp 60.37% <ø> (+11.48%) ⬆️
...behavior_velocity_planner/src/utilization/util.cpp 20.47% <0.00%> (+3.62%) ⬆️
..._planner/test/src/test_risk_predictive_braking.cpp 67.56% <ø> (ø)
...ocity_planner/src/scene_module/run_out/manager.cpp 0.00% <0.00%> (ø)
...nner/src/scene_module/run_out/dynamic_obstacle.cpp 0.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 merged commit 9a1ada0 into autowarefoundation:main Aug 21, 2022
@taikitanaka3 taikitanaka3 deleted the refactor/occlusion_spot branch August 21, 2022 13:41
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…ier4#1628)

* refactor(occlusion_spot): remove unused functions and refactor utils

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* style: fix pre-commit

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ier4#1628)

* refactor(occlusion_spot): remove unused functions and refactor utils

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* style: fix pre-commit

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ier4#1628)

* refactor(occlusion_spot): remove unused functions and refactor utils

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* style: fix pre-commit

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…utowarefoundation#1628)

* refactor(occlusion_spot): remove unused functions and refactor utils

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* style: fix pre-commit

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…ier4#1628)

* refactor(occlusion_spot): remove unused functions and refactor utils

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* style: fix pre-commit

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Nov 25, 2024
…l-door-interface-qos

hotfix: fix internal door interface qos (autowarefoundation#9144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants