-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(occlusion_spot): remove unused functions and refactor utils #1628
refactor(occlusion_spot): remove unused functions and refactor utils #1628
Conversation
Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Codecov Report
@@ Coverage Diff @@
## main #1628 +/- ##
==========================================
+ Coverage 10.78% 10.80% +0.02%
==========================================
Files 1109 1109
Lines 78426 78831 +405
Branches 18521 18769 +248
==========================================
+ Hits 8457 8517 +60
- Misses 61114 61438 +324
- Partials 8855 8876 +21
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ier4#1628) * refactor(occlusion_spot): remove unused functions and refactor utils Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp> * style: fix pre-commit Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
…ier4#1628) * refactor(occlusion_spot): remove unused functions and refactor utils Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp> * style: fix pre-commit Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
…ier4#1628) * refactor(occlusion_spot): remove unused functions and refactor utils Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp> * style: fix pre-commit Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
…utowarefoundation#1628) * refactor(occlusion_spot): remove unused functions and refactor utils Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp> * style: fix pre-commit Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
…ier4#1628) * refactor(occlusion_spot): remove unused functions and refactor utils Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp> * style: fix pre-commit Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
…l-door-interface-qos hotfix: fix internal door interface qos (autowarefoundation#9144)
Description
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.