Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix internal door interface qos #9144

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Oct 23, 2024

Description

Fix QoS of vehicle doors interface.

Related links

Parent Issue:

How was this PR tested?

  1. Launch ros2 launch vehicle_door_simulator vehicle_door_simulator.launch.xml
  2. Launch planning simulator
  3. Check ros2 topic echo /api/vehicle/doors/status is published

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) labels Oct 23, 2024
Copy link

github-actions bot commented Oct 23, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@isamu-takagi isamu-takagi marked this pull request as ready for review October 29, 2024 07:05
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi enabled auto-merge (squash) October 29, 2024 09:12
@isamu-takagi isamu-takagi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 29, 2024
@isamu-takagi isamu-takagi merged commit b6f9ef8 into autowarefoundation:main Oct 29, 2024
25 of 26 checks passed
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.61%. Comparing base (589fee4) to head (edd2990).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...mulator/vehicle_door_simulator/src/dummy_doors.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9144      +/-   ##
==========================================
- Coverage   28.64%   28.61%   -0.04%     
==========================================
  Files        1312     1313       +1     
  Lines      101648   101259     -389     
  Branches    39464    39298     -166     
==========================================
- Hits        29116    28973     -143     
+ Misses      69695    69483     -212     
+ Partials     2837     2803      -34     
Flag Coverage Δ *Carryforward flag
differential 28.13% <0.00%> (?)
total 28.49% <ø> (-0.15%) ⬇️ Carriedforward from c67712a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mkuri pushed a commit to tier4/autoware.universe that referenced this pull request Nov 7, 2024
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
mkuri added a commit to tier4/autoware.universe that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants