-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_velocity_planner): create and use util functions #1599
refactor(behavior_velocity_planner): create and use util functions #1599
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1599 +/- ##
==========================================
- Coverage 10.77% 10.71% -0.07%
==========================================
Files 1111 1111
Lines 78548 79676 +1128
Branches 18555 19293 +738
==========================================
+ Hits 8465 8538 +73
- Misses 61226 62193 +967
- Partials 8857 8945 +88
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@takayuki5168 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this change but please wait for other approvers
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
cd2a291
to
8b254f4
Compare
I confirmed that every maintainer approved the changes and no degration was found. |
…ier4#1599) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…ier4#1599) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…ier4#1599) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…utowarefoundation#1599) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…ier4#1599) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka takayuki5168@gmail.com
Description
refactor behavior velocity planner by creating and using util functions.
fix #361
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.