Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_planner): create and use util functions #1599

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 16, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

refactor behavior velocity planner by creating and using util functions.
fix #361

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 marked this pull request as ready for review August 16, 2022 15:38
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #1599 (8b254f4) into main (7176ea5) will decrease coverage by 0.06%.
The diff coverage is 13.75%.

@@            Coverage Diff             @@
##             main    #1599      +/-   ##
==========================================
- Coverage   10.77%   10.71%   -0.07%     
==========================================
  Files        1111     1111              
  Lines       78548    79676    +1128     
  Branches    18555    19293     +738     
==========================================
+ Hits         8465     8538      +73     
- Misses      61226    62193     +967     
- Partials     8857     8945      +88     
Flag Coverage Δ *Carryforward flag
differential 4.74% <5.88%> (?)
total 10.76% <21.42%> (ø) Carriedforward from 7176ea5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...n_capture_rviz_plugin/src/screen_capture_panel.cpp 0.00% <0.00%> (ø)
...n_capture_rviz_plugin/src/screen_capture_panel.hpp 0.00% <ø> (ø)
...ene_module/occlusion_spot/occlusion_spot_utils.hpp 57.14% <ø> (ø)
...y_planner/include/scene_module/stop_line/scene.hpp 0.00% <ø> (ø)
...city_planner/include/utilization/arc_lane_util.hpp 28.35% <0.00%> (-12.07%) ⬇️
...vior_velocity_planner/include/utilization/util.hpp 0.00% <0.00%> (ø)
...city_planner/src/scene_module/blind_spot/scene.cpp 0.00% <0.00%> (ø)
...ocity_planner/src/scene_module/crosswalk/debug.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/crosswalk/scene_crosswalk.cpp 0.00% <0.00%> (ø)
...anner/src/scene_module/crosswalk/scene_walkway.cpp 0.00% <0.00%> (ø)
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@taikitanaka3
Copy link
Contributor

@takayuki5168
can you run CI to check if there is no degration?

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this change but please wait for other approvers

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the refactor/behavior-vel branch from cd2a291 to 8b254f4 Compare August 18, 2022 12:24
@takayuki5168
Copy link
Contributor Author

I confirmed that every maintainer approved the changes and no degration was found.
https://evaluation.tier4.jp/evaluation/reports/e6a4142d-21d1-5fb2-b73f-a3efe5111c09?project_id=prd_jt (TIER IV internal link)

@takayuki5168 takayuki5168 merged commit 9ef82dc into autowarefoundation:main Aug 18, 2022
@takayuki5168 takayuki5168 deleted the refactor/behavior-vel branch August 18, 2022 14:51
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…ier4#1599)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ier4#1599)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ier4#1599)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…utowarefoundation#1599)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…ier4#1599)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There are duplicate parameters and functions in behavior_velocity_planner
2 participants