revert(crosswalk): reduce processing time (#2137) #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: for cherry-picking #175, we should also cherry-pick this large-refactoring PR autowarefoundation#1599 and many other related PRs. |
taikitanaka3
approved these changes
Nov 11, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## beta/v0.5.2-odaiba3 #179 +/- ##
=====================================================
Coverage ? 4.75%
=====================================================
Files ? 80
Lines ? 6207
Branches ? 3329
=====================================================
Hits ? 295
Misses ? 5724
Partials ? 188
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
shmpwk
approved these changes
Nov 11, 2022
tkimura4
changed the title
tkimura4
changed the title
tkimura4
deleted the
revert-175-hotfix/reduce-crosswalk-processing-time
branch
maxime-clem
pushed a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Feb 7, 2024
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #175
Autoware upstream and beta/v0.5.2 have large code differences in crosswalk module, and it causes bugs when cherry-picking simply.
I Revert the PR as this is hard to fix.