Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_stop_planner): use common ego nearest search #1552

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 10, 2022

Description

use the new nearest index search algorithm in obstacle stop planner to deal with edge cases shown in the issue.

Related links

issue
#1581

depends on
#1582
tier4/autoware_launch#437

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the fix/obstacle-stop-nearest-ego branch from bad0cc9 to 87ca3f0 Compare August 10, 2022 02:47
@takayuki5168 takayuki5168 changed the title Fix/obstacle stop nearest ego fix(obstacle_stop_planner): use common ego nearest search Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1552 (5fe70c7) into main (6f75dad) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1552      +/-   ##
==========================================
- Coverage   10.74%   10.69%   -0.06%     
==========================================
  Files        1115     1115              
  Lines       78815    79186     +371     
  Branches    18560    18560              
==========================================
  Hits         8465     8465              
- Misses      61492    61863     +371     
  Partials     8858     8858              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.72% <0.00%> (ø) Carriedforward from a25f8cf

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/obstacle_stop_planner/src/node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@takayuki5168 takayuki5168 marked this pull request as ready for review August 15, 2022 05:09
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168
Copy link
Contributor Author

No need to modify tier4_planning_launch and planning_launch since the removed parameter is not contained in these laucher's yaml files.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota
Copy link
Contributor

@takayuki5168 Should we merge this PR with tier4/autoware_launch#437 ?

@takayuki5168
Copy link
Contributor Author

@satoshi-ota Yes.
Give me LGTM in these PRs.
tier4/autoware_launch#437
#1582

@takayuki5168
Copy link
Contributor Author

I confirmed this PR worked well with tier4's and awf's meta repository.

@takayuki5168 takayuki5168 merged commit 6a0e1e9 into autowarefoundation:main Aug 17, 2022
@takayuki5168 takayuki5168 deleted the fix/obstacle-stop-nearest-ego branch August 17, 2022 02:37
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* fix(obstacle_stop_planner): use common ego nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* fix(obstacle_stop_planner): use common ego nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* fix(obstacle_stop_planner): use common ego nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 13, 2022
* fix(obstacle_stop_planner): use common ego nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 13, 2022
* fix(obstacle_stop_planner): use common ego nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 13, 2022
* fix(obstacle_stop_planner): use common ego nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…undation#1552)

* fix(obstacle_stop_planner): use common ego nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 18, 2022
* fix(obstacle_stop_planner): use common ego nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* fix(obstacle_stop_planner): use common ego nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Nov 10, 2022
* fix(obstacle_stop_planner): use common ego nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Nov 30, 2022
* fix(obstacle_stop_planner): use common ego nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants