-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(map_based_prediction): fix object yaw and velocity when necessary #1358
feat(map_based_prediction): fix object yaw and velocity when necessary #1358
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
[Q] |
@taikitanaka3 No, this PR is independent of #1348 |
Codecov Report
@@ Coverage Diff @@
## main #1358 +/- ##
========================================
- Coverage 9.64% 9.60% -0.04%
========================================
Files 1096 1096
Lines 77124 77433 +309
Branches 17705 17705
========================================
Hits 7441 7441
- Misses 62443 62752 +309
Partials 7240 7240
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
perception/map_based_prediction/src/map_based_prediction_node.cpp
Outdated
Show resolved
Hide resolved
perception/map_based_prediction/src/map_based_prediction_node.cpp
Outdated
Show resolved
Hide resolved
perception/map_based_prediction/src/map_based_prediction_node.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1358) * feat(map_based_prediction): fix object yaw and velocity when necessary Signed-off-by: yutaka <purewater0901@gmail.com> * fix condition Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * delete unnecessary part Signed-off-by: yutaka <purewater0901@gmail.com>
tier4#1358) * feat(map_based_prediction): fix object yaw and velocity when necessary Signed-off-by: yutaka <purewater0901@gmail.com> * fix condition Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * delete unnecessary part Signed-off-by: yutaka <purewater0901@gmail.com>
tier4#1358) * feat(map_based_prediction): fix object yaw and velocity when necessary Signed-off-by: yutaka <purewater0901@gmail.com> * fix condition Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * delete unnecessary part Signed-off-by: yutaka <purewater0901@gmail.com>
tier4#1358) * feat(map_based_prediction): fix object yaw and velocity when necessary Signed-off-by: yutaka <purewater0901@gmail.com> * fix condition Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * delete unnecessary part Signed-off-by: yutaka <purewater0901@gmail.com>
autowarefoundation#1358) * feat(map_based_prediction): fix object yaw and velocity when necessary Signed-off-by: yutaka <purewater0901@gmail.com> * fix condition Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * delete unnecessary part Signed-off-by: yutaka <purewater0901@gmail.com>
tier4#1358) * feat(map_based_prediction): fix object yaw and velocity when necessary Signed-off-by: yutaka <purewater0901@gmail.com> * fix condition Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * delete unnecessary part Signed-off-by: yutaka <purewater0901@gmail.com>
…ntrol-cmd-switcher feat: add control cmd switcher
Signed-off-by: yutaka purewater0901@gmail.com
Description
Currently, map based prediction has a serious issue that cannot handle the wrong yaw angle of the object. In order to fix this problem, I changed the condition and object yaw and velocity when necessary.
map_based_prediction-2022-07-15_16.15.20.mp4
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.