Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the implementation of sigmoid() in lidar_centerpoint package is not right #1545

Closed
3 tasks done
WfHit opened this issue Aug 9, 2022 · 3 comments · Fixed by #1555
Closed
3 tasks done

the implementation of sigmoid() in lidar_centerpoint package is not right #1545

WfHit opened this issue Aug 9, 2022 · 3 comments · Fixed by #1555
Assignees
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)

Comments

@WfHit
Copy link
Contributor

WfHit commented Aug 9, 2022

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

The implementation of sigmoid() in lidar_centerpoint package is not right. The current implementation will return value greater than 1, and cause a lot of false positives.

Expected behavior

device inline float sigmoid(float x) { return 1.0f / (1.0f + expf(-x)); }

Actual behavior

device inline float sigmoid(float x) { return 1.0f / expf(-x); }

Steps to reproduce

sigmoid() is defined at 50 line in postprocess_kernel.cu

Versions

No response

Possible causes

No response

Additional context

No response

@miursh miursh added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 9, 2022
@miursh
Copy link
Contributor

miursh commented Aug 9, 2022

@yukke42 Could you please confirm this?

@yukke42
Copy link
Contributor

yukke42 commented Aug 9, 2022

@WfHit Thank you for your kind feedback. Cloud you make a PR to fix this bug?

@WfHit
Copy link
Contributor Author

WfHit commented Aug 9, 2022

OK, I will fix it as soon as possible

WfHit added a commit to WfHit/autoware.universe that referenced this issue Aug 9, 2022
WfHit added a commit to WfHit/autoware.universe that referenced this issue Aug 10, 2022
WfHit added a commit to WfHit/autoware.universe that referenced this issue Aug 10, 2022
Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>
yukke42 pushed a commit that referenced this issue Aug 10, 2022
fix(lidar_centerpoint): fix function sigmoid() (#1545)

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>
kosuke55 referenced this issue in tier4/autoware.universe Aug 12, 2022
fix(lidar_centerpoint): fix function sigmoid() (#1545)

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>
kosuke55 referenced this issue in tier4/autoware.universe Aug 13, 2022
fix(lidar_centerpoint): fix function sigmoid() (#1545)

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>
yukke42 referenced this issue in tier4/autoware.universe Aug 18, 2022
fix(lidar_centerpoint): fix function sigmoid() (#1545)

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>
yukke42 referenced this issue in tier4/autoware.universe Sep 8, 2022
fix(lidar_centerpoint): fix function sigmoid() (#1545)

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>
boyali referenced this issue in boyali/autoware.universe Sep 28, 2022
fix(lidar_centerpoint): fix function sigmoid() (tier4#1545)

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>
boyali referenced this issue in boyali/autoware.universe Oct 3, 2022
fix(lidar_centerpoint): fix function sigmoid() (tier4#1545)

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>
boyali referenced this issue in boyali/autoware.universe Oct 3, 2022
fix(lidar_centerpoint): fix function sigmoid() (tier4#1545)

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>
tkimura4 referenced this issue in tier4/autoware.universe Oct 7, 2022
fix(lidar_centerpoint): fix function sigmoid() (#1545)

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>
tkimura4 referenced this issue in tier4/autoware.universe Oct 14, 2022
fix(lidar_centerpoint): fix function sigmoid() (#1545)

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>
tkimura4 referenced this issue in tier4/autoware.universe Oct 14, 2022
* fix(lidar_centerpoint): fix function sigmoid()  (#1555)

fix(lidar_centerpoint): fix function sigmoid() (#1545)

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>

* feat(lidar_centerpoint): add score threshold parameter to center point (#1699)

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>

* feat(behavior_path_planner): add new turn signal algorithm (autowarefoundation#1964)

* clean code

Signed-off-by: yutaka <purewater0901@gmail.com>

* clean format

Signed-off-by: yutaka <purewater0901@gmail.com>

* udpate

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* add test

Signed-off-by: yutaka <purewater0901@gmail.com>

* add test

* add test

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix(avoidance): use new turn signal algorithm

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): fix desired_start_point position

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* change policy

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(behavior_path_planner): update pull_over for new blinker logic

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(behavior_path_planner): update pull_out for new blinker logic

* tmp: install flask via pip

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(lane_change): added lane change point

* fix start_point and non backward driving turn signal

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* get 3 second during constructing lane change path

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix pull over desired start point

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* delete

Signed-off-by: yutaka <purewater0901@gmail.com>

* Update Readme

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

* fix format

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix(lidar_centerpoint): include zero in range of yaw_norm_threshold (autowarefoundation#1830)

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

* feat(multi_object_tracker): increase max-area for truck and trailer (#1710)

* feat(multi_object_tracker): increase max-area for truck

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* feat: change truck and trailer max-area gate params

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* feat: change trailer params

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat(multi_object_tracker): update bus size (autowarefoundation#1887)

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix(multi_object_tracker): add missing trailer tracker (autowarefoundation#1885)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* feat(lidar_centerpoint): implemented a class remapping according to the detections shape (autowarefoundation#1876)

* Implemented a small package to remap detection classes depending on their shape

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Update perception/detection_class_adapter/include/detection_class_adapter/detection_class_adapter.hpp

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Removed the hardcoded mapping from centerpoint and pointfusion. Fixed the description of the config file

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Deleted the new package and moved the logic to centerpoint

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Update perception/lidar_centerpoint/config/detection_class_adapter.param.yaml

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Changed: adapter->remapper

* Update perception/lidar_centerpoint/lib/detection_class_remapper.cpp

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Delted duplicated file

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Modified the parameters to match #1710
Now we do not map cars to buses no mather the size

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Update perception/lidar_centerpoint/config/detection_class_remapper.param.yaml

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat(lidar_centerpoint): add IoU-based NMS (autowarefoundation#1935)

* feat(lidar_centerpoint): add IoU-based NMS

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* feat: add magic number name

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* feat: remove unnecessary headers

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* fix: typo

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* fix: typo

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat(lidar_centerpoint): enabled per class yaw norm threshold (autowarefoundation#1962)

* feat(lidar_centerpoint): enabled per class yaw norm threshold

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Updated thresholds

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Moved the yaw threshold parameters to gpu memory

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Moved the thresholds as a member variable

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix(lidar_centeproint): fix cmake

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* revert(lidar_centerpoint): "fix(lidar_centeproint): fix cmake"

This reverts commit 2efc31d.

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* chore(lidar_centerpoint): add trained model of centerpoint (#1202)

* chore(lidar_centerpoint): add trained model of centerpoint

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* docs: add description of models

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: WfHit <33973397+WfHit@users.noreply.github.com>
Co-authored-by: Satoshi Tanaka <16330533+scepter914@users.noreply.github.com>
Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: yukke42 <yusuke.muramatsu@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this issue Oct 14, 2022
fix(lidar_centerpoint): fix function sigmoid() (autowarefoundation#1545)

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>
0x126 referenced this issue in tier4/autoware.universe Oct 17, 2022
fix(lidar_centerpoint): fix function sigmoid() (#1545)

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>
boyali referenced this issue in boyali/autoware.universe Oct 19, 2022
fix(lidar_centerpoint): fix function sigmoid() (tier4#1545)

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this issue Jan 16, 2023
* fix(lidar_centerpoint): fix function sigmoid()  (autowarefoundation#1555)

fix(lidar_centerpoint): fix function sigmoid() (autowarefoundation#1545)

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>

* feat(lidar_centerpoint): add score threshold parameter to center point (autowarefoundation#1699)

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>

* feat(behavior_path_planner): add new turn signal algorithm (autowarefoundation#1964)

* clean code

Signed-off-by: yutaka <purewater0901@gmail.com>

* clean format

Signed-off-by: yutaka <purewater0901@gmail.com>

* udpate

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* add test

Signed-off-by: yutaka <purewater0901@gmail.com>

* add test

* add test

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix(avoidance): use new turn signal algorithm

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): fix desired_start_point position

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* change policy

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(behavior_path_planner): update pull_over for new blinker logic

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(behavior_path_planner): update pull_out for new blinker logic

* tmp: install flask via pip

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(lane_change): added lane change point

* fix start_point and non backward driving turn signal

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* get 3 second during constructing lane change path

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix pull over desired start point

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* delete

Signed-off-by: yutaka <purewater0901@gmail.com>

* Update Readme

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

* fix format

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix(lidar_centerpoint): include zero in range of yaw_norm_threshold (autowarefoundation#1830)

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

* feat(multi_object_tracker): increase max-area for truck and trailer (autowarefoundation#1710)

* feat(multi_object_tracker): increase max-area for truck

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* feat: change truck and trailer max-area gate params

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* feat: change trailer params

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat(multi_object_tracker): update bus size (autowarefoundation#1887)

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix(multi_object_tracker): add missing trailer tracker (autowarefoundation#1885)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* feat(lidar_centerpoint): implemented a class remapping according to the detections shape (autowarefoundation#1876)

* Implemented a small package to remap detection classes depending on their shape

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Update perception/detection_class_adapter/include/detection_class_adapter/detection_class_adapter.hpp

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Removed the hardcoded mapping from centerpoint and pointfusion. Fixed the description of the config file

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Deleted the new package and moved the logic to centerpoint

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Update perception/lidar_centerpoint/config/detection_class_adapter.param.yaml

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Changed: adapter->remapper

* Update perception/lidar_centerpoint/lib/detection_class_remapper.cpp

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Delted duplicated file

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Modified the parameters to match autowarefoundation#1710
Now we do not map cars to buses no mather the size

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Update perception/lidar_centerpoint/config/detection_class_remapper.param.yaml

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat(lidar_centerpoint): add IoU-based NMS (autowarefoundation#1935)

* feat(lidar_centerpoint): add IoU-based NMS

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* feat: add magic number name

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* feat: remove unnecessary headers

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* fix: typo

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* fix: typo

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat(lidar_centerpoint): enabled per class yaw norm threshold (autowarefoundation#1962)

* feat(lidar_centerpoint): enabled per class yaw norm threshold

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Updated thresholds

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Moved the yaw threshold parameters to gpu memory

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Moved the thresholds as a member variable

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix(lidar_centeproint): fix cmake

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* revert(lidar_centerpoint): "fix(lidar_centeproint): fix cmake"

This reverts commit 2efc31d.

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* chore(lidar_centerpoint): add trained model of centerpoint (autowarefoundation#1202)

* chore(lidar_centerpoint): add trained model of centerpoint

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* docs: add description of models

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: WfHit <33973397+WfHit@users.noreply.github.com>
Co-authored-by: Satoshi Tanaka <16330533+scepter914@users.noreply.github.com>
Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: yukke42 <yusuke.muramatsu@tier4.jp>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this issue Feb 2, 2023
* fix(lidar_centerpoint): fix function sigmoid()  (autowarefoundation#1555)

fix(lidar_centerpoint): fix function sigmoid() (autowarefoundation#1545)

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>

* feat(lidar_centerpoint): add score threshold parameter to center point (autowarefoundation#1699)

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>

* feat(behavior_path_planner): add new turn signal algorithm (autowarefoundation#1964)

* clean code

Signed-off-by: yutaka <purewater0901@gmail.com>

* clean format

Signed-off-by: yutaka <purewater0901@gmail.com>

* udpate

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* add test

Signed-off-by: yutaka <purewater0901@gmail.com>

* add test

* add test

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix(avoidance): use new turn signal algorithm

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): fix desired_start_point position

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* change policy

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(behavior_path_planner): update pull_over for new blinker logic

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(behavior_path_planner): update pull_out for new blinker logic

* tmp: install flask via pip

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(lane_change): added lane change point

* fix start_point and non backward driving turn signal

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* get 3 second during constructing lane change path

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix pull over desired start point

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* delete

Signed-off-by: yutaka <purewater0901@gmail.com>

* Update Readme

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

* fix format

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix(lidar_centerpoint): include zero in range of yaw_norm_threshold (autowarefoundation#1830)

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

* feat(multi_object_tracker): increase max-area for truck and trailer (autowarefoundation#1710)

* feat(multi_object_tracker): increase max-area for truck

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* feat: change truck and trailer max-area gate params

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* feat: change trailer params

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat(multi_object_tracker): update bus size (autowarefoundation#1887)

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix(multi_object_tracker): add missing trailer tracker (autowarefoundation#1885)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* feat(lidar_centerpoint): implemented a class remapping according to the detections shape (autowarefoundation#1876)

* Implemented a small package to remap detection classes depending on their shape

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Update perception/detection_class_adapter/include/detection_class_adapter/detection_class_adapter.hpp

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Removed the hardcoded mapping from centerpoint and pointfusion. Fixed the description of the config file

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Deleted the new package and moved the logic to centerpoint

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Update perception/lidar_centerpoint/config/detection_class_adapter.param.yaml

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Changed: adapter->remapper

* Update perception/lidar_centerpoint/lib/detection_class_remapper.cpp

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Delted duplicated file

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Modified the parameters to match autowarefoundation#1710
Now we do not map cars to buses no mather the size

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Update perception/lidar_centerpoint/config/detection_class_remapper.param.yaml

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat(lidar_centerpoint): add IoU-based NMS (autowarefoundation#1935)

* feat(lidar_centerpoint): add IoU-based NMS

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* feat: add magic number name

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* feat: remove unnecessary headers

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* fix: typo

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* fix: typo

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat(lidar_centerpoint): enabled per class yaw norm threshold (autowarefoundation#1962)

* feat(lidar_centerpoint): enabled per class yaw norm threshold

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Updated thresholds

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Moved the yaw threshold parameters to gpu memory

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Moved the thresholds as a member variable

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix(lidar_centeproint): fix cmake

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* revert(lidar_centerpoint): "fix(lidar_centeproint): fix cmake"

This reverts commit 2efc31d.

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* chore(lidar_centerpoint): add trained model of centerpoint (autowarefoundation#1202)

* chore(lidar_centerpoint): add trained model of centerpoint

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* docs: add description of models

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: WfHit <33973397+WfHit@users.noreply.github.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: WfHit <33973397+WfHit@users.noreply.github.com>
Co-authored-by: Satoshi Tanaka <16330533+scepter914@users.noreply.github.com>
Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: yukke42 <yusuke.muramatsu@tier4.jp>
technolojin pushed a commit to technolojin/autoware.universe that referenced this issue Oct 28, 2024
…lc_warning

fix(lane_change): set initial rtc state properly (autowarefoundation#8902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment