-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(how-to): rename how to guide section #147
Conversation
Signed-off-by: Lalith Vipulananthan <lalith.vipulananthan@tier4.jp>
Signed-off-by: Lalith Vipulananthan <lalith.vipulananthan@tier4.jp>
#126 is unfortunately blocked due to a merge conflict that I wasn't able to resolve, so I thought it might be quicker to submit a clean new PR instead. |
@LalithVipulananthan I'm sorry but I wanted you to wait for my review. 😢
So I recommend reverting this. What do you think? |
Also, if you want to change the structure, which is a relatively big change, you had to write more background information and reasons in the description so that others can understand it. |
@kenji-miyake I apologise for both merging without your review and for the lack of detail in the PR. Based on your comment on @soblin's original PR, I had assumed that you were okay with the proposed structural change and so that's why I didn't give so much detail for this PR and also why I merged it as soon as @soblin approved the PR. Whilst we are here, @kminoda was proposing that the scenario testing tutorials should be moved into an advanced tutorials section, which kind of overlaps with this PR. Perhaps it would be an idea to create a Design discussion to make proposals and suggestions on how to handle advanced tutorials and how-to guides? |
@LalithVipulananthan I'm sorry for my unclear comment. 🙇 But I just commented and didn't approve it.
It wasn't good because the reasons of changes aren't clear if I see #126.
I think it's good, but to do that, we didn't have to move all contents from how-to guides.
Yes, it's a good idea. But before that, I think it's good to revert this to avoid confusion. |
For example, considering |
Understood. So, what is the best way to revert this change? |
This reverts commit cc47234.
Description
Rename "how-to guide" section to "advanced" and move to the tutorials folder
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.