Remove Default trait bound from engine IO #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
commented
Nov 9, 2021
| @@ -62,11 +61,15 @@ pub struct OnTransferMessageData { | |||
| pub fee: U256, | |||
| } | |||
|
|
|||
| impl<I: IO + Default + Copy> EthConnectorContract<I> { | |||
| impl<I: IO + Copy> EthConnectorContract<I> { | |||
There was a problem hiding this comment.
Copy (or at the very least Clone) is still required, unfortunately. The reason is because the engine and connector sub-components benefit from having a handle to the IO they can access in self methods (otherwise we end up passing in io all over the place and it's pretty messy). I think it might be ok if this ends up remaining the case in the long term, but perhaps in a future PR I'll see if I can sort out all the lifetimes to be able to pass a reference down instead of the actual object.
birchmd
added a commit
to birchmd/aurora-engine
that referenced
this pull request
Nov 10, 2021
birchmd
force-pushed
the
sdk-refactor-revisited-continued
branch
from
f077841
to
fe13e1d
Compare
birchmd
added a commit
to birchmd/aurora-engine
that referenced
this pull request
Nov 10, 2021
birchmd
force-pushed
the
sdk-refactor-revisited-continued
branch
from
fe13e1d
to
6d621a6
Compare
birchmd
added a commit
to birchmd/aurora-engine
that referenced
this pull request
Nov 11, 2021
This was referenced Nov 11, 2021
joshuajbouw
suggested changes
Nov 14, 2021
joshuajbouw
approved these changes
Nov 15, 2021
birchmd
force-pushed
the
sdk-refactor-revisited-continued
branch
from
339dc43
to
490d586
Compare
artob
pushed a commit
that referenced
this pull request
Dec 10, 2021
* Feat(engine): London hard fork support (#244) * Fix(exit precompile): Address to refund in case of error is an argument (#311) * Feat(engine): Make engine parametric in storage access (#314) * Test verifying the EVM log returns the correct address (#341) * Remove sdk::current_account_id usage from engine-precompiles (#346) * Remove Default trait bound from engine IO (#342) * Remove some sdk usage from core logic (#347) * Factor out blockchain environment variable access as a trait (#349) * Factor out NEAR promise host functions into a trait (#353) * Borsh deserialized value field for call args (#351) * Refactor(eth-connector): Use Result return values instead of panicking (#355) * Gate all NEAR host functions behind the contract feature (#356) * Bump @openzeppelin/contracts from 4.3.2 to 4.3.3 in /etc/eth-contracts * Chore: Newtypes for gas (#344) * Feat(standalone): Standalone (#345) * Minor fixes to sdk refactor (#359) * Refactor(engine): Move submit logic into engine module (#366) * Feat(standalone): Storage backend (#375) * NEAR random numbers from solidity contract (#368) * Feat(standalone): EVM tracing via SputnikVM (#383) * Feat(standalone): Bootstrap storage from relayer and state snapshots (#379) * Feat(standalone): Structures and logic for keeping storage in sync with the blockchain (#382) * Feat(standalone): Capture geth-like tracing from SputnikVM events (#384) * Connector cleanup (#374) * Remove betanet * Fix(engine): original_storage bug fix; more tracing tests (#390) * Increase NEAR Gas for ft_on_transfer (#389) Co-authored-by: Andrew Bednoff <andrew.bednoff@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Evgeny Ukhanov <evgeny.ukhanov@aurora.dev> Co-authored-by: Marcelo Fornet <marcelo.fornet@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this PR is to remove the
Defaulttrait bound that was required on theIOtype after #314 . The primary reason for this trait bound was the usage ofDefaultinLookupMapandBijectionMap. As a result, this PR removesLookupMapand refactorsBijectionMapto no longer have aDefaultimplementation, as well as to be more type-safe.This is change does not impact the runtime behaviour of the engine in any way. It is continuing the path towards being able to run the engine without the NEAR runtime (ie as a standalone binary).