Add initial EIP-1559 support #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuajbouw
force-pushed
the
develop
branch
from
21bf309
to
422844a
Compare
joshuajbouw
added
C-dependencies
joshuajbouw
removed
S-do-not-merge
|
Unblocked as per #280 |
birchmd
reviewed
Sep 23, 2021
birchmd
requested changes
Sep 23, 2021
birchmd
force-pushed
the
develop
branch
2 times, most recently
from
95563ee
to
cdc9235
Compare
birchmd
force-pushed
the
feat/london/eip-1559
branch
from
7e3ce01
to
a76eae5
Compare
birchmd
force-pushed
the
develop
branch
2 times, most recently
from
758c04e
to
abef91a
Compare
birchmd
force-pushed
the
feat/london/eip-1559
branch
from
e6cd2ff
to
d0afb89
Compare
birchmd
approved these changes
Oct 22, 2021
| fn gas_price(&self) -> U256 { | ||
| U256::zero() | ||
| self.gas_price |
There was a problem hiding this comment.
A noteworthy change. This improves our EVM compatibility.
| /// | ||
| /// TODO: doc.aurora.dev link | ||
| fn block_base_fee_per_gas(&self) -> U256 { | ||
| U256::zero() |
There was a problem hiding this comment.
We'll probably want to make this part of the state as some point, and allow it to be set by the engine contract owner. But this is fine for now.
| } | ||
|
|
||
| // TODO: upgrade to Berlin HF | ||
| pub(crate) const CONFIG: &Config = &Config::istanbul(); | ||
| pub(crate) const CONFIG: &Config = &Config::london(); |
There was a problem hiding this comment.
Also a noteworthy change.
(Also apparently we never actually updated to the Berlin config, oops.)
birchmd
force-pushed
the
feat/london/eip-1559
branch
from
aca38dc
to
6e0436f
Compare
|
@joshuajbouw I can't tag you as a reviewer of your own PR, but please take a look. I think this is ready to merge now. We'll need to update our docs about the |
|
Thanks buddy. Yes. Agreed. |
birchmd
force-pushed
the
feat/london/eip-1559
branch
from
6e0436f
to
bfd0b37
Compare
birchmd
added a commit
that referenced
this pull request
Nov 5, 2021
birchmd
force-pushed
the
feat/london/eip-1559
branch
from
dd7ed7a
to
0ef113f
Compare
birchmd
force-pushed
the
feat/london/eip-1559
branch
from
0ef113f
to
b904fd0
Compare
birchmd
added a commit
that referenced
this pull request
Nov 10, 2021
Merged
artob
pushed a commit
that referenced
this pull request
Dec 10, 2021
* Feat(engine): London hard fork support (#244) * Fix(exit precompile): Address to refund in case of error is an argument (#311) * Feat(engine): Make engine parametric in storage access (#314) * Test verifying the EVM log returns the correct address (#341) * Remove sdk::current_account_id usage from engine-precompiles (#346) * Remove Default trait bound from engine IO (#342) * Remove some sdk usage from core logic (#347) * Factor out blockchain environment variable access as a trait (#349) * Factor out NEAR promise host functions into a trait (#353) * Borsh deserialized value field for call args (#351) * Refactor(eth-connector): Use Result return values instead of panicking (#355) * Gate all NEAR host functions behind the contract feature (#356) * Bump @openzeppelin/contracts from 4.3.2 to 4.3.3 in /etc/eth-contracts * Chore: Newtypes for gas (#344) * Feat(standalone): Standalone (#345) * Minor fixes to sdk refactor (#359) * Refactor(engine): Move submit logic into engine module (#366) * Feat(standalone): Storage backend (#375) * NEAR random numbers from solidity contract (#368) * Feat(standalone): EVM tracing via SputnikVM (#383) * Feat(standalone): Bootstrap storage from relayer and state snapshots (#379) * Feat(standalone): Structures and logic for keeping storage in sync with the blockchain (#382) * Feat(standalone): Capture geth-like tracing from SputnikVM events (#384) * Connector cleanup (#374) * Remove betanet * Fix(engine): original_storage bug fix; more tracing tests (#390) * Increase NEAR Gas for ft_on_transfer (#389) Co-authored-by: Andrew Bednoff <andrew.bednoff@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Evgeny Ukhanov <evgeny.ukhanov@aurora.dev> Co-authored-by: Marcelo Fornet <marcelo.fornet@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial EIP-1559 support for the London hardfork.
There has been numerous changes done in this PR. Notably, I made a geth-like
NormalizedEthTransactionwhich given the current fork will use that structure. This is important as for the first time instead of adding fields, 1 was taken away, and 2 additional were added so it led to a bit of a large redesign.