Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test verifying the EVM log returns the correct address #341

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

birchmd
Copy link
Member

@birchmd birchmd commented Nov 9, 2021

Adds a test showing the correct address is returned by the engine.

This means the issue reported in #336 must not come from the engine, and instead must arise from elsewhere (maybe the relayer?).

Closes #336

@birchmd birchmd added the A-testing Area: If something has added tests, or changed them. label Nov 9, 2021
@birchmd birchmd linked an issue Nov 9, 2021 that may be closed by this pull request
Copy link
Contributor

@0x3bfc 0x3bfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @birchmd. This proves that it is not an engine related issue which is great. Will continue troubleshooting other components.

@0x3bfc
Copy link
Contributor

0x3bfc commented Nov 10, 2021

@birchmd after troubleshooting, it seems to be a relayer issue. The handling of the address value in the event always relies on the transaction.to value which is not the right way to handle such important information.

That's actually a relief because it can be resolved by reindexing.

More details will be followed here aurora-is-near/aurora-relayer#118

@birchmd birchmd merged commit 965b403 into develop Nov 10, 2021
@birchmd birchmd deleted the 336-log-address branch November 10, 2021 13:19
artob pushed a commit that referenced this pull request Dec 10, 2021
* Feat(engine): London hard fork support (#244)
* Fix(exit precompile): Address to refund in case of error is an argument (#311)
* Feat(engine): Make engine parametric in storage access (#314)
* Test verifying the EVM log returns the correct address (#341)
* Remove sdk::current_account_id usage from engine-precompiles (#346)
* Remove Default trait bound from engine IO (#342)
* Remove some sdk usage from core logic (#347)
* Factor out blockchain environment variable access as a trait (#349)
* Factor out NEAR promise host functions into a trait (#353)
* Borsh deserialized value field for call args (#351)
* Refactor(eth-connector): Use Result return values instead of panicking (#355)
* Gate all NEAR host functions behind the contract feature (#356)
* Bump @openzeppelin/contracts from 4.3.2 to 4.3.3 in /etc/eth-contracts
* Chore: Newtypes for gas (#344)
* Feat(standalone): Standalone (#345)
* Minor fixes to sdk refactor (#359)
* Refactor(engine): Move submit logic into engine module (#366)
* Feat(standalone): Storage backend (#375)
* NEAR random numbers from solidity contract (#368)
* Feat(standalone): EVM tracing via SputnikVM (#383)
* Feat(standalone): Bootstrap storage from relayer and state snapshots (#379)
* Feat(standalone): Structures and logic for keeping storage in sync with the blockchain (#382)
* Feat(standalone): Capture geth-like tracing from SputnikVM events (#384)
* Connector cleanup (#374)
* Remove betanet
* Fix(engine): original_storage bug fix; more tracing tests (#390)
* Increase NEAR Gas for ft_on_transfer (#389)

Co-authored-by: Andrew Bednoff <andrew.bednoff@aurora.dev>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Evgeny Ukhanov <evgeny.ukhanov@aurora.dev>
Co-authored-by: Marcelo Fornet <marcelo.fornet@aurora.dev>
Co-authored-by: Michael Birch <michael.birch@aurora.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Area: If something has added tests, or changed them.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid low level EVM function call behaviour
2 participants