JPERF-188: Improve stopJira to wait for Jira process to shutdown inst… #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzyromski-atlassian
requested review from
dagguh,
sebapawlak and
wyrzyk
as code owners
wyrzyk
previously approved these changes
Feb 20, 2020
…ead of all Java processes on the node
mzyromski-atlassian
force-pushed
the
KonradMarszalek/issue/JPERF-188-improve-stop-jira-condition
branch
from
e0c6c0a to
d110ba8
Compare
|
This is #82 adopted by @mzyromski-atlassian to cover the CI. /cc @KonradMarszalek |
dagguh
suggested changes
Feb 25, 2020
| @@ -88,8 +88,10 @@ class CustomDatasetSource( | |||
|
|
|||
| private fun stopJira(host: SshHost) { | |||
| val shutdownTomcat = "echo SHUTDOWN | nc localhost 8005" | |||
| val waitForNoJavaProcess = "while ps -C java -o pid=; do sleep 5; done" | |||
| Ssh(host, connectivityPatience = 4).newConnection().use { it.safeExecute("$shutdownTomcat && $waitForNoJavaProcess", Duration.ofMinutes(3)) } | |||
| val waitForNoJiraProcess = "while pgrep -f jira; do sleep 5; done" | |||
There was a problem hiding this comment.
Gotta fix that infinite loop from CI
|
It seems there are more processes with |
|
Alternatively we could read PID from the PID file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ead of all Java processes on the node