Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JPERF-188: Improve stopJira to wait for Jira process to shutdown inst… #82

Closed
wants to merge 1 commit into from
Closed

JPERF-188: Improve stopJira to wait for Jira process to shutdown inst… #82

wants to merge 1 commit into from

Conversation

konradmars
Copy link

JPERF-188: Improve stopJira to wait for Jira process to shutdown instead of all Java processes on the node

Renamed branch and commit

Added Changelog entry

@dagguh
Copy link
Contributor

dagguh commented Feb 19, 2020

FYI branch name doesn't really matter and the commit message can be amended and force-pushed. You have full permissions and control over your fork.

@dagguh dagguh mentioned this pull request Feb 19, 2020
Closed
@dagguh
Copy link
Contributor

dagguh commented Feb 19, 2020

Actually, according to myself, it's testable via the existing AwsDatasetModificationIT, which is better, because it directly pertains to dataset manipulations and covers both ends of the CustomDatasetSource - saving and reusing.
We just gotta add the second Java process and again, according to myself it's about using the AtlassianSplunkForwarder.
@KonradMarszalek LMK if you wanna adapt the test. If not, we're attacking this PR with @mzyromski-atlassian anyway, so we can cover that as an exercise.

@konradmars
Copy link
Author

@KonradMarszalek LMK if you wanna adapt the test

If possible I leave you to it as I just had coffee-break contribution capacity.

@dagguh
Copy link
Contributor

dagguh commented Feb 19, 2020

Awesome, thanks for the fix and the manual test ❤️

@dagguh dagguh mentioned this pull request Feb 25, 2020
Open
@dagguh
Copy link
Contributor

dagguh commented Feb 25, 2020

Adopted in #84 with CI

@dagguh dagguh closed this Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyrzyk wyrzyk wyrzyk approved these changes

@dagguh dagguh Awaiting requested review from dagguh

@sebapawlak sebapawlak Awaiting requested review from sebapawlak

@mzyromski-atlassian mzyromski-atlassian Awaiting requested review from mzyromski-atlassian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@konradmars @dagguh @wyrzyk