JPERF-188: Improve stopJira to wait for Jira process to shutdown inst…

…ead of all Java processes on the node
atlassian · Feb 21, 2020 · d110ba8 · d110ba8
1 parent 15efbcd
commit d110ba8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -28,6 +28,7 @@ Dropping a requirement of a major version of a dependency is a new contract.
 - Dial down the provisioning logging amount.
 - Enrich the provisioning logging messages.
 - Fix `UriJiraFormula` failing to download results due to zero nodes and zero threads.
+- Improve `stopJira` to wait only for Jira process shutdown instead of all Java processes
 
 [JPERF-595]: https://ecosystem.atlassian.net/browse/JPERF-595
 

diff --git a/src/main/kotlin/com/atlassian/performance/tools/awsinfrastructure/api/CustomDatasetSource.kt b/src/main/kotlin/com/atlassian/performance/tools/awsinfrastructure/api/CustomDatasetSource.kt
@@ -88,8 +88,10 @@ class CustomDatasetSource(
 
     private fun stopJira(host: SshHost) {
         val shutdownTomcat = "echo SHUTDOWN | nc localhost 8005"
-        val waitForNoJavaProcess = "while ps -C java -o pid=; do sleep 5; done"
-        Ssh(host, connectivityPatience = 4).newConnection().use { it.safeExecute("$shutdownTomcat && $waitForNoJavaProcess", Duration.ofMinutes(3)) }
+        val waitForNoJiraProcess = "while pgrep -f jira; do sleep 5; done"
+        Ssh(host, connectivityPatience = 4).newConnection().use {
+            it.safeExecute("$shutdownTomcat && $waitForNoJiraProcess", Duration.ofMinutes(3))
+        }
     }
 
     private fun stopDockerContainers(host: SshHost) {