Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deleted ToolsList from /docs/tools #1364

Merged
merged 12 commits into from
Mar 1, 2023

Conversation

akshatnema
Copy link
Member

Description

Removed the ToolsList from the /docs/tools directory and redirected the viewers to use new Tools Dashboard.

Related issue(s)
Resolves #1217

Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
@netlify
Copy link

netlify bot commented Feb 23, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 30ab72d
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63ff514572a005000821a7aa
😎 Deploy Preview https://deploy-preview-1364--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Feb 23, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 63
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1364--asyncapi-website.netlify.app/

@akshatnema
Copy link
Member Author

@alequetzalli @derberg Please have a look over the changes and if you have better suggestions on how we can improve the content for the /docs/tools, kindly inform me regarding that.

@akshatnema akshatnema changed the title fix: deleted the ToolsList from /docs/tools fix: deleted ToolsList from /docs/tools Feb 23, 2023
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving it entirely to @alequetzalli
my only feedback is to avoid new and we have shifted way of writing, because for new comers and also others in few months it will just sound strange.

so better just communicate where all tools are listed, and not that it is a new way.

I hope it makes sense 😄

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost ready, just a couple changes needed ✨

quetzalliwrites and others added 3 commits February 27, 2023 18:23
Co-authored-by: Alejandra Quetzalli  <alejandra.olvera.novack@gmail.com>
Co-authored-by: Alejandra Quetzalli  <alejandra.olvera.novack@gmail.com>
@akshatnema
Copy link
Member Author

Hey @derberg, since we are removing Tools & Services link from the Community dropdown, should we add a Dashboard option in the Tools dropdown to enable users to know that we have the Tools Dashboard too? I know we have referenced the Dashboard by clicking directly on the Tools but on my opinion we should have option inside dropdown to indicate that we have Tools Dashboard too.

@derberg
Copy link
Member

derberg commented Mar 1, 2023

@akshatnema

Hey @derberg, since we are removing Tools & Services link from the Community dropdown, should we add a Dashboard option in the Tools dropdown to enable users to know that we have the Tools Dashboard too? I know we have referenced the Dashboard by clicking directly on the Tools but on my opinion we should have option inside dropdown to indicate that we have Tools Dashboard too.

I suggest we tackle it in a separate issue

@akshatnema
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 977de63 into asyncapi:master Mar 1, 2023
@akshatnema akshatnema deleted the del-tools branch March 31, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: removal of Docs Tool page from website
4 participants