Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Modelina to tools list #1300

Closed
wants to merge 1 commit into from

Conversation

jonaslagoni
Copy link
Member

Description
Saw Modelina was missing from the tools list.

@netlify
Copy link

netlify bot commented Feb 6, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6ca0b38
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63e1454307d3bf000916e505
😎 Deploy Preview https://deploy-preview-1300--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 60
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1300--asyncapi-website.netlify.app/

@akshatnema
Copy link
Member

Hey @jonaslagoni, you are actually updating the wrong file for adding modelina in tolos list. We have a new Tools dashboard that works on .asyncapi-tool file automation. Please have a look in the documentation regarding it and the update the PR regarding it.

@jonaslagoni
Copy link
Member Author

@jonaslagoni
Copy link
Member Author

Ahh, you are referring to two different pages. Creating a PR for that as well.

@quetzalliwrites
Copy link
Member

should we close this PR since we will be removing the Tools list info from the Docs now that the tools dashboard is live? 🤔

@jonaslagoni
Copy link
Member Author

@alequetzalli depends on when that will happen 😄?

@derberg
Copy link
Member

derberg commented Feb 28, 2023

@jonaslagoni have some more faith 😄 the other PR to remove old list is "one second away from Akshat merging it" - quoting every single word @alequetzalli said during website PRs triage meeting 😄

@jonaslagoni closing PR in favour of #1364

@derberg derberg closed this Feb 28, 2023
@jonaslagoni jonaslagoni deleted the patch-2 branch February 28, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants