-
-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Modelina to tools list #1300
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1300--asyncapi-website.netlify.app/ |
Hey @jonaslagoni, you are actually updating the wrong file for adding modelina in tolos list. We have a new Tools dashboard that works on |
How come it works then? 🧐 https://deploy-preview-1300--asyncapi-website.netlify.app/docs/tools I just used the link on the site (in the top): https://github.com/asyncapi/website/blob/master/pages/docs/tools/index.md |
Ahh, you are referring to two different pages. Creating a PR for that as well. |
should we close this PR since we will be removing the Tools list info from the Docs now that the tools dashboard is live? 🤔 |
@alequetzalli depends on when that will happen 😄? |
@jonaslagoni have some more faith 😄 the other PR to remove old list is "one second away from Akshat merging it" - quoting every single word @alequetzalli said during website PRs triage meeting 😄 @jonaslagoni closing PR in favour of #1364 |
Description
Saw Modelina was missing from the tools list.