refactor: rewrite Schema component #269
Conversation
magicmatatjahu
added
enhancement
| schema?: Schema; | ||
| required?: boolean; | ||
| isCircular?: boolean; | ||
| odd?: boolean; |
There was a problem hiding this comment.
odd looks weird to me. What does it mean that a prop is odd? (I know what it means, just want you to think about it from a different perspective).
Should this be called something like darkBackground or lightBackground or something like this? Something that refers more to what it actually does.
There was a problem hiding this comment.
Maybe this light/dark background thingy can be handled outside this component? For instance, the NewSchema component is transparent and the color of the background is handled in the parent component.
There was a problem hiding this comment.
The odd I "copied" from HTML template and you probably understood what it is - it "checks" that another schema renders in another nested schema like oneOf or object as prop in another object. Of course we can call this nested or something like that, but HTML template do it in proper way - odd indicated also how nested schema is. darkBackground or lightBackground is good, but we should choose only one.
Maybe this light/dark background thingy can be handled outside this component? For instance, the NewSchema component is transparent and the color of the background is handled in the parent component.
The main problem with it are very nested schemas and style "wrappers" for them. Transparent of schema should works only for 'root' schema, not for nested. I will try to check something like:
.schema .schema {
// light styles
}
.schema .schema .schema {
// dark styles
}There was a problem hiding this comment.
Ok, I removed odd prop and made "odd" styles using pure css combinators.
|
Kudos, SonarCloud Quality Gate passed!
|
|
@fmvilas I think that you haven't problem with logic, but you had one, which i corrected. Let me merge, because PR itself blocks the rest of the things - channels and messages parts :) As if there are any bugs, we will fix them in next PRs. |
|
No, I have no other problems than the |
|
🎉 This PR is included in version 0.21.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Changes proposed in this pull request:
Rewrite Schema component:
NewSchemacomponent which will replace in next PRs oldSchemacomponent - I don't want to rewrite everything in one PRoneOf,anyOf,allOfadditionalPropertiesandadditionalItemsNewSchemacomponent.dummyspec to Playground.New look:
I know that some styles don't look nice, but this PR is only to "switch" to new way of rendering, styling will be done as part asyncapi/shape-up-process#86 in next PR.
Related issue(s)
Part of asyncapi/shape-up-process#87
Part of asyncapi/shape-up-process#86