Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify styling in react-component - like in HTML template #86

Closed
magicmatatjahu opened this issue Mar 15, 2021 · 8 comments
Closed

Unify styling in react-component - like in HTML template #86

magicmatatjahu opened this issue Mar 15, 2021 · 8 comments
Assignees
Labels
Epic Scope Scopes are groups of related tasks.

Comments

@magicmatatjahu
Copy link
Member

React component uses from beginning "fiori" styling. We should start using styling from HTML (TailwindCSS) to have unified styling across studio, component and website.

@magicmatatjahu magicmatatjahu added Scope Scopes are groups of related tasks. Epic labels Mar 15, 2021
@asyncapi-bot
Copy link

Hey! You've labeled this issue as a Scope. Remember you can use the following command to inform about its progress:

/progress <percentage> [message]

or

/progress <percentage>

A mutiline message.
It supports **Markdown**.
Example:
/progress 40 We're still figuring out how to implement this. We have an idea but it is not yet confirmed it will work.
/progress 50

A few notes:

* We got this figured out :tada:
* We're going to use [this library](#link-to-website) to avoid losing time implementing this algorithm.
* We decided to go for the quickest solution and will improve it if we got time at the end of the cycle.

🏋️‍♀️ See the progress on the Shape Up Dashboard.

@magicmatatjahu
Copy link
Member Author

/progress 10 Start using TailwindCSS in react-component. First PR: asyncapi/asyncapi-react#269

@magicmatatjahu
Copy link
Member Author

/progress 15 Info component uses TailwindCSS - commit

@magicmatatjahu
Copy link
Member Author

/progress 60 In asyncapi/asyncapi-react#296:

  • add config for TailwindCSS
  • styling Info, half of Servers, Operations, Message, Schema
  • left to styling: Sidebar, Examples for Message and mobile menu.

@magicmatatjahu
Copy link
Member Author

/progress 75 In asyncapi/asyncapi-react#296:

  • styling missed parts in Servers, Operations, Messages.
  • left to styling: Sidebar, Examples for Message (for html-template resolution) and for mobiles.

@magicmatatjahu
Copy link
Member Author

magicmatatjahu commented Apr 18, 2021

/progress 90 In asyncapi/asyncapi-react#301:

  • styling Sidebar, Examples for Message (for html-template resolution) and for mobiles.

@magicmatatjahu
Copy link
Member Author

/progress 99 Waiting for review in asyncapi/asyncapi-react#310 It's a last PR before the "final" PR to master. There is a 1-2 days delay in delivering the task (let's see how long it will take to merge), but I think that the task is finished, it's only waiting for review (partially done in asyncapi/html-template#166) and merge.

@magicmatatjahu
Copy link
Member Author

/progress 100 asyncapi/asyncapi-react#310 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Scope Scopes are groups of related tasks.
Projects
None yet
Development

No branches or pull requests

2 participants