Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parser-js in react-component #85

Closed
magicmatatjahu opened this issue Mar 15, 2021 · 11 comments
Closed

Use parser-js in react-component #85

magicmatatjahu opened this issue Mar 15, 2021 · 11 comments
Assignees
Labels
Epic Scope Scopes are groups of related tasks.

Comments

@magicmatatjahu
Copy link
Member

magicmatatjahu commented Mar 15, 2021

Internally in component we still use schema in inline way by schema.info.contact.email. We should start using parser-js and remove old typings inside component (or maybe leave?).

@magicmatatjahu magicmatatjahu added Scope Scopes are groups of related tasks. Epic labels Mar 15, 2021
@asyncapi-bot
Copy link

Hey! You've labeled this issue as a Scope. Remember you can use the following command to inform about its progress:

/progress <percentage> [message]

or

/progress <percentage>

A mutiline message.
It supports **Markdown**.
Example:
/progress 40 We're still figuring out how to implement this. We have an idea but it is not yet confirmed it will work.
/progress 50

A few notes:

* We got this figured out :tada:
* We're going to use [this library](#link-to-website) to avoid losing time implementing this algorithm.
* We decided to go for the quickest solution and will improve it if we got time at the end of the cycle.

🏋️‍♀️ See the progress on the Shape Up Dashboard.

@fmvilas
Copy link
Member

fmvilas commented Mar 15, 2021

I'd be careful with this one. It seems to have a lot of potential for becoming a rabbit hole 😄

Let's consider this one as a nice-to-have.

@magicmatatjahu
Copy link
Member Author

@fmvilas We have covered at least 90% of our api in parser-js so I think that it shouldn't be rabbit hole, only one: new api for parser, but then we can switch to new one without problem (I think 😄).

@fmvilas
Copy link
Member

fmvilas commented Mar 15, 2021

I honestly can't foresee the implications of this Scope. I just know that it doesn't add anything valuable for the user. I know that making the code maintainable is a great thing but don't forget we're going to "redo" the whole React component in a future cycle, once we start implementing the UI library. So not sure it's worth the effort now.

@magicmatatjahu
Copy link
Member Author

magicmatatjahu commented Mar 15, 2021

Yes, I agree with you but parser-js has some helper functions like allSchemas etc - this is one of requirements in bet description (It has a section of messages and schemas but it only shows the ones under components.) to handle rendering also the anonymous-schemas used as inline schema in oneOf etc. I will check if here is a problem to move in everyplace to parser-js but in some we should - I don't want to duplicate code from parser-js.

@magicmatatjahu
Copy link
Member Author

/progress 5 Starting task

@magicmatatjahu magicmatatjahu changed the title Use parser-js in react-component everywhere Use parser-js in react-component Mar 15, 2021
@magicmatatjahu
Copy link
Member Author

/progress 15 Info and Servers components are using parser-js api

@magicmatatjahu magicmatatjahu self-assigned this Mar 15, 2021
@magicmatatjahu
Copy link
Member Author

/progress 50 Info, Servers, Channels, Messages are using parser-js api. I left Schemas, because this part should be rewritten to meet the requirements of the task #86

@magicmatatjahu
Copy link
Member Author

/progress 55 Open PR - asyncapi/asyncapi-react#264 Changes will be merged to unify-component branch.

@magicmatatjahu
Copy link
Member Author

/progress 85 New component for Schema (in PR) already uses parser-js API. After adapting components that use the old Schema component, the beautify stage will be removed and the task will be marked as completed.

@magicmatatjahu
Copy link
Member Author

/progress 100 "New" component supports in every place parser API. PR with removing beautifier asyncapi/asyncapi-react#285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Scope Scopes are groups of related tasks.
Projects
None yet
Development

No branches or pull requests

3 participants