-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use parser-js in react-component #85
Comments
Hey! You've labeled this issue as a Scope. Remember you can use the following command to inform about its progress:
or
Example:
🏋️♀️ See the progress on the Shape Up Dashboard. |
I'd be careful with this one. It seems to have a lot of potential for becoming a rabbit hole 😄 Let's consider this one as a nice-to-have. |
@fmvilas We have covered at least 90% of our api in parser-js so I think that it shouldn't be rabbit hole, only one: new api for parser, but then we can switch to new one without problem (I think 😄). |
I honestly can't foresee the implications of this Scope. I just know that it doesn't add anything valuable for the user. I know that making the code maintainable is a great thing but don't forget we're going to "redo" the whole React component in a future cycle, once we start implementing the UI library. So not sure it's worth the effort now. |
Yes, I agree with you but parser-js has some helper functions like |
/progress 5 Starting task |
/progress 15 Info and Servers components are using |
/progress 50 Info, Servers, Channels, Messages are using |
/progress 55 Open PR - asyncapi/asyncapi-react#264 Changes will be merged to |
/progress 85 New component for Schema (in PR) already uses |
/progress 100 "New" component supports in every place parser API. PR with removing |
Internally in component we still use schema in inline way by
schema.info.contact.email
. We should start usingparser-js
and remove old typings inside component (or maybe leave?).The text was updated successfully, but these errors were encountered: