This repository has been archived by the owner on May 25, 2022. It is now read-only.
Fixing extension warnings raised by sphinx 1.4 #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first warning is coming from this https://github.com/astropy/astropy-helpers/blob/master/astropy_helpers/sphinx/ext/autodoc_enhancements.py#L75 I tried to catch the warning there and ignore it, but it didn't work. Getting the bug workaround into upstream sphinx may be the best long term solution. |
bsipocz
added a commit
to bsipocz/astropy-helpers
that referenced
this pull request
Apr 15, 2016
bsipocz
added a commit
to bsipocz/astropy-helpers
that referenced
this pull request
Apr 15, 2016
bsipocz
added a commit
to bsipocz/astropy-helpers
that referenced
this pull request
Apr 15, 2016
|
Well, this one looks fine so I'll go ahead and merge and create a seperate issue for the remaning one. |
|
@astrofrog - another one for backportation |
7 tasks
astrofrog
pushed a commit
to astropy/sphinx-astropy
that referenced
this pull request
Jan 29, 2018
…x_deprecations Fixed one of the warnings raised by sphinx 1.4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two new warnings coming from the new 1.4 Sphinx. This causes travis failures for the sphinx builds for packages using astropy-helpers. The proposed workaround astropy/ci-helpers#78 is to set the version to a previous release, however on the long term, it's better to deal with them here.
This PR addresses the second warning, as I'm not yet sure how to fix the first one.
[edit: I've cancelled the appveyor build as it's irrelevant and there was a queue for other packages]