This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Temporary fixing of sphinx version to be <1.4 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Current failures are addressed by #76, I plan to merge it first, and then rebase this.) |
…failures on travis for any packages that uses astropy-helpers and the -w option
bsipocz
force-pushed
the
travis_fix_sphinx_version
branch
from
b972b38
to
b4465a1
Compare
This was referenced Apr 13, 2016
bsipocz
force-pushed
the
travis_fix_sphinx_version
branch
from
b4465a1
to
fedca50
Compare
| if [[ ! -z $SPHINX_VERSION ]]; then | ||
| if [[ -z $(grep sphinx $pin_file) ]]; then | ||
| echo "matplotlib ${SPHINX_VERSION}*" >> $pin_file | ||
| echo "sphinx ${SPHINX_VERSION}*" >> $pin_file |
There was a problem hiding this comment.
Yes, clearly no one tried to set the sphinx version before.
|
I agree with this solution - it's not like any of the packages are using Sphinx 1.4 features. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new 1.4 sphinx we run into 2 WARNINGS. This affects every package that uses astropy-helpers, thus I think it's sensible to add a requirement for the sphinx version to be
<1.4here and not at the package level.For packages that run the sphinx build without the
-woption, and thus are insensitive of these warnings, there is an option to use theSPHINX_VERSIONvariable to override this limitation.We can remove this once the issue is address in the helpers.
The warnings are:
@astrofrog - What do you think?