Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

Fix the remaining sphinx 1.4 warning #227

Closed
eteq opened this issue Apr 15, 2016 · 3 comments
Closed

Fix the remaining sphinx 1.4 warning #227

eteq opened this issue Apr 15, 2016 · 3 comments

Comments

@eteq
Copy link
Member

eteq commented Apr 15, 2016

As discussed in #224, sphinx 1.4 has caused two new warnings to appear. One was fixed in #224, but this one remains:

WARNING: while setting up extension astropy_helpers.sphinx.ext.autodoc_enhancements: directive 'autoattribute' is already registered, it will be overridden

And from #224 (comment):

The first warning is coming from this https://github.com/astropy/astropy-helpers/blob/master/astropy_helpers/sphinx/ext/autodoc_enhancements.py#L75

I tried to catch the warning there and ignore it, but it didn't work. Getting the bug workaround into upstream sphinx may be the best long term solution.
@bsipocz
Copy link
Member

bsipocz commented Apr 15, 2016

btw @embray made a PR to sphinx with the patch here: sphinx-doc/sphinx#1843

@eteq
Copy link
Member Author

eteq commented Apr 15, 2016

And I'm noticing you've suggested an in-sphinx fix in sphinx-doc/sphinx#2451

@bsipocz
Copy link
Member

bsipocz commented Apr 15, 2016

Yes, either way would work. I tried to implement the latter but over-complicated it, and still didn't manage to get it work.

@eteq eteq mentioned this issue Apr 19, 2016
Merged
@eteq eteq closed this as completed in 26bfcdd Apr 20, 2016
@eteq eteq mentioned this issue Apr 20, 2016
Closed
bsipocz pushed a commit to bsipocz/astropy-helpers that referenced this issue Jun 10, 2016
@eteq @bsipocz
work around sphinx 1.4 warning
557e7be 
this is terribly hacky, but it's the only way I see to supress the warning.
The warning is actually a red herring, because we *mean* to override the
directive in question...

closes astropy#227
bsipocz pushed a commit to bsipocz/astropy-helpers that referenced this issue Jul 6, 2016
@eteq @bsipocz
work around sphinx 1.4 warning
34b7a65 
this is terribly hacky, but it's the only way I see to supress the warning.
The warning is actually a red herring, because we *mean* to override the
directive in question...

closes astropy#227
@larrybradley larrybradley mentioned this issue Sep 28, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eteq @bsipocz