Fix documentation of descriptor classes that have a custom metaclass #1843
Conversation
(i.e. a subclass of type). This avoids using string comparisons to do type checks, except in the case of the fix for sphinx-doc#1155, since in Python 3 there really seems to be no way to export the instancemethod type, short of using ctypes.
Adds a possible (?) workaround to sphinx-doc/sphinx#1843
Adds a possible (?) workaround to sphinx-doc/sphinx#1843
|
See #1526 for some related discussion imported from Bitbucket. |
|
Thanks, somehow I didn't see the existing issue (figured this was pretty obscure). This should fix #1526. |
|
@shimizukawa @embray - I wonder what's the status of this? We have this workaround locally in |
|
I dunno. Looks to me like the status is I made a PR and it works, but hasn't bee merged yet shrug. |
|
Sorry for my late reply. |
|
I can rebase the PR if it will help. |
|
@embray Thanks! |
|
OK, I can merge this PR into stable by hand. For CI testing, I pushed it as branch named '1843'. |
|
Now CI passed. |
|
Finally this PR is merged into stable branch by hand as: 3284e89. |
|
@shimizukawa - Thanks for merging this. Could you tell which version it will be released? I'm asking, so we know when to remove the workarounds on our side. |
|
It will come next 1.5 beta release (and 1.4.10 if exists) |
|
Thanks sorry I wasn't able to get to it, I've been on a (brief) vacation. LGTM as merged! |
…ue-1843 Adds a possible (?) workaround to sphinx-doc/sphinx#1843
…ue-1843 Adds a possible (?) workaround to sphinx-doc/sphinx#1843
(i.e. a subclass of type). This avoids using string comparisons to do
type checks, except in the case of the fix for #1155, since in Python 3
there really seems to be no way to export the instancemethod type, short
of using ctypes.
The attached test demonstrates the issue that this fixes--previously such classes were identified as data attributes.