Change load_options to list[LoadOptions] from LoadOptions #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkarsharma2
requested review from
dimberman,
tatiana,
sunank200,
pankajastro,
pankajkoti and
feluelle
as code owners
Codecov ReportBase: 94.06% // Head: 94.17% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1540 +/- ##
==========================================
+ Coverage 94.06% 94.17% +0.11%
==========================================
Files 89 89
Lines 4417 4450 +33
Branches 440 444 +4
==========================================
+ Hits 4155 4191 +36
+ Misses 178 174 -4
- Partials 84 85 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
utkarsharma2
changed the title
tatiana
reviewed
Jan 6, 2023
tatiana
reviewed
Jan 6, 2023
tatiana
reviewed
Jan 6, 2023
tatiana
reviewed
Jan 6, 2023
tatiana
reviewed
Jan 6, 2023
tatiana
reviewed
Jan 9, 2023
tatiana
reviewed
Jan 9, 2023
utkarsharma2
force-pushed
the
change_load_options
branch
from
46f2cd1 to
18659e0
Compare
for more information, see https://pre-commit.ci
utkarsharma2
force-pushed
the
change_load_options
branch
from
18659e0 to
7b6cecb
Compare
for more information, see https://pre-commit.ci
dimberman
approved these changes
Jan 9, 2023
for more information, see https://pre-commit.ci
utkarsharma2
added a commit
that referenced
this pull request
Jan 17, 2023
# Description ## What is the current behavior? In load_file() we use multiple integrations with Pandas, and Databases at the same time. But We currently just have one parameter to pass in integration-specific parameters. closes: #1532 ## What is the new behavior? We have changed load_options params to List[LoadOptions] so that we can pass multiple integration parameters in a list. Passing multiple values to `load_options` leads to the problem of mapping. How do we know that PandasLoadOptions need to be passed to dataframe specific methods? We solved the mapping problem by having integration classes having `LOAD_OPTIONS_CLASS_NAME` parameter to store the `LoadOptions` subclass for that integration and initialize the File-type, File-location, and Database objects with the right LoadOption class. ## Does this introduce a breaking change? No, since we never released the `load_options` ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] Extended the README / documentation, if necessary
2 tasks
2 tasks
utkarsharma2
added a commit
that referenced
this pull request
Feb 8, 2023
# Description ## What is the current behavior? load_options exposed to the user in File location/type added in the following PR - #1540. Since it's a derived property and not something the user should set. Concerns load_options shouldn't be exposed to the end users in the File class. load_options is specific to load_file() and should not be part of File/Databases. closes: #1719 ## What is the new behavior? We added a getter/setter property on the File class such that the load_option interface is not exposed to the end user. ## Does this introduce a breaking change? Yes ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] Extended the README / documentation, if necessary
utkarsharma2
added a commit
that referenced
this pull request
Feb 8, 2023
# Description ## What is the current behavior? load_options exposed to the user in File location/type added in the following PR - #1540. Since it's a derived property and not something the user should set. Concerns load_options shouldn't be exposed to the end users in the File class. load_options is specific to load_file() and should not be part of File/Databases. closes: #1719 ## What is the new behavior? We added a getter/setter property on the File class such that the load_option interface is not exposed to the end user. ## Does this introduce a breaking change? Yes ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] Extended the README / documentation, if necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
In load_file() we use multiple integrations with Pandas, and Databases at the same time. But We currently just have one parameter to pass in integration-specific parameters.
closes: #1532
What is the new behavior?
We have changed load_options params to List[LoadOptions] so that we can pass multiple integration parameters in a list.
Passing multiple values to
load_optionsleads to the problem of mapping. How do we know that PandasLoadOptions need to be passed to dataframe specific methods?We solved the mapping problem by having integration classes having
LOAD_OPTIONS_CLASS_NAMEparameter to store theLoadOptionssubclass for that integration and initialize the File-type, File-location, and Database objects with the right LoadOption class.Does this introduce a breaking change?
No, since we never released the
load_optionsChecklist