-
Notifications
You must be signed in to change notification settings - Fork 48
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move load_options out from the File object (#1721)
# Description ## What is the current behavior? load_options exposed to the user in File location/type added in the following PR - #1540. Since it's a derived property and not something the user should set. Concerns load_options shouldn't be exposed to the end users in the File class. load_options is specific to load_file() and should not be part of File/Databases. closes: #1719 ## What is the new behavior? We added a getter/setter property on the File class such that the load_option interface is not exposed to the end user. ## Does this introduce a breaking change? Yes ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] Extended the README / documentation, if necessary
- Loading branch information
1 parent
c212f4d
commit 61a371d
Showing
3 changed files
with
33 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters