Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load_options exposed to user in File - location/type #1719

Closed
2 tasks
sunank200 opened this issue Feb 7, 2023 · 0 comments · Fixed by #1721
Closed
2 tasks

load_options exposed to user in File - location/type #1719

sunank200 opened this issue Feb 7, 2023 · 0 comments · Fixed by #1721
Assignees
@utkarsharma2
Milestone
1.5.0

Comments

@sunank200
Copy link
Contributor

sunank200 commented Feb 7, 2023 •
edited by utkarsharma2
Loading

Describe the bug
load_options exposed to the user in File location/type added in the following PR - #1540. Since it's a derived property and not something the user should set.

Concerns
load_options shouldn't be exposed to the end users in the File class.
load_options is specific to load_file() and should not be part of File/Databases.

ref - https://astronomer.slack.com/archives/C03868KGF2Q/p1675690013077239

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary
@sunank200 sunank200 added this to the 1.5.0 milestone Feb 7, 2023
@utkarsharma2 utkarsharma2 mentioned this issue Feb 7, 2023
Merged
2 tasks
utkarsharma2 added a commit that referenced this issue Feb 8, 2023
@utkarsharma2
Move load_options out from the File object (#1721)
61a371d 
# Description
## What is the current behavior?
load_options exposed to the user in File location/type added in the
following PR - #1540. Since
it's a derived property and not something the user should set.

Concerns
load_options shouldn't be exposed to the end users in the File class.
load_options is specific to load_file() and should not be part of
File/Databases.

closes: #1719


## What is the new behavior?
We added a getter/setter property on the File class such that the
load_option interface is not exposed to the end user.

## Does this introduce a breaking change?
Yes

### Checklist
- [ ] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary
utkarsharma2 added a commit that referenced this issue Feb 8, 2023
@utkarsharma2
Move load_options out from the File object (#1721)
c799a59 
# Description
## What is the current behavior?
load_options exposed to the user in File location/type added in the
following PR - #1540. Since
it's a derived property and not something the user should set.

Concerns
load_options shouldn't be exposed to the end users in the File class.
load_options is specific to load_file() and should not be part of
File/Databases.

closes: #1719


## What is the new behavior?
We added a getter/setter property on the File class such that the
load_option interface is not exposed to the end user.

## Does this introduce a breaking change?
Yes

### Checklist
- [ ] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@utkarsharma2 utkarsharma2

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Move load_options out from the File object astronomer/astro-sdk
2 participants
@sunank200 @utkarsharma2