Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: do not run e2e/runfiles on non-bzlmod #1986

Merged
merged 1 commit into from
Oct 17, 2024
Merged

build: do not run e2e/runfiles on non-bzlmod #1986

merged 1 commit into from
Oct 17, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Oct 16, 2024 •
edited
Loading

See bazel-contrib/rules_nodejs#3797

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Oct 16, 2024 •
edited
Loading

Test

All tests were cache hits

203 tests (100.0%) were fully cached saving 39s.

Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 789ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 169ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 9s.

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 920ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 924ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 27ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 27ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 296ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 112ms.

Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 233ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 236ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 81ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 81ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 504ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

40 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 2s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

12 tests (100.0%) were fully cached saving 3s.

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 493ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 153ms.

Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 413ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 171ms.

Buildifier      Format

@jbedard jbedard force-pushed the runfiles-bazel7-disable branch 3 times, most recently from ad99531 to 43d4af3 Compare October 16, 2024 23:58
@jbedard jbedard changed the base branch from main to bump_to_latest_bazel October 16, 2024 23:58
@jbedard jbedard force-pushed the bump_to_latest_bazel branch from 85b2dd3 to 9f2e0b6 Compare October 16, 2024 23:59
@jbedard jbedard force-pushed the runfiles-bazel7-disable branch from 43d4af3 to f941f19 Compare October 16, 2024 23:59
@jbedard jbedard marked this pull request as ready for review October 17, 2024 00:01
@jbedard jbedard changed the base branch from bump_to_latest_bazel to main October 17, 2024 00:03
@jbedard jbedard requested a review from gregmagolan October 17, 2024 00:06
@jbedard jbedard force-pushed the runfiles-bazel7-disable branch from f941f19 to c7a18cb Compare October 17, 2024 00:13
@jbedard jbedard requested a review from dzbarsky October 17, 2024 00:13
@jbedard jbedard force-pushed the runfiles-bazel7-disable branch 2 times, most recently from 9611cbe to dcb63da Compare October 17, 2024 00:21
@jbedard jbedard mentioned this pull request Oct 17, 2024
Merged
gregmagolan
gregmagolan approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jbedard jbedard force-pushed the runfiles-bazel7-disable branch 2 times, most recently from 7ee20a0 to c739ff6 Compare October 17, 2024 03:36
@jbedard jbedard changed the title build: only run e2e/runfiles on bazel6 when non-bzlmod build: do not run e2e/runfiles on non-bzlmod Oct 17, 2024
@jbedard jbedard enabled auto-merge (rebase) October 17, 2024 03:36
@jbedard jbedard disabled auto-merge October 17, 2024 03:36
@jbedard jbedard force-pushed the runfiles-bazel7-disable branch 2 times, most recently from d0fe87e to 669c3bd Compare October 17, 2024 03:52
@jbedard jbedard force-pushed the runfiles-bazel7-disable branch from 669c3bd to 833734c Compare October 17, 2024 03:59
@jbedard jbedard merged commit 7724c04 into aspect-build:main Oct 17, 2024
65 of 68 checks passed
@jbedard jbedard deleted the runfiles-bazel7-disable branch October 17, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

@dzbarsky dzbarsky Awaiting requested review from dzbarsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @gregmagolan