Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade bazel to v7.3.2 #1969

Merged
merged 1 commit into from
Oct 17, 2024
Merged

chore: upgrade bazel to v7.3.2 #1969

merged 1 commit into from
Oct 17, 2024

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Oct 9, 2024

No description provided.

@gregmagolan gregmagolan requested a review from jbedard October 9, 2024 20:11
Copy link

aspect-workflows bot commented Oct 9, 2024

Test

All tests were cache hits

203 tests (100.0%) were fully cached saving 39s.


Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 789ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 169ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 8s.


Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 920ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 924ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 27ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 27ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 296ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 112ms.


Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 233ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 236ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 81ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 81ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 504ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

40 tests (100.0%) were fully cached saving 3s.


Test

e2e/pnpm_workspace

Buildkite build #6433 is running...


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

12 tests (100.0%) were fully cached saving 3s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 493ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 153ms.


Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 413ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 171ms.


Buildifier      Format

@jbedard jbedard force-pushed the bump_to_latest_bazel branch 5 times, most recently from 85b2dd3 to 9f2e0b6 Compare October 16, 2024 23:59
@jbedard
Copy link
Member

jbedard commented Oct 17, 2024

@gregmagolan with my additional XDG commit in this PR along with #1986 (non-bzlmod runfiles broken in bazel7) and #1987 (bazel-lib missing a fix in bzlmod) then the only remaining failures should be the windows ones.

@jbedard jbedard force-pushed the bump_to_latest_bazel branch from 9f2e0b6 to bfe2390 Compare October 17, 2024 02:53
@jbedard jbedard requested a review from dzbarsky October 17, 2024 03:56
@jbedard jbedard force-pushed the bump_to_latest_bazel branch from bfe2390 to bf0a6ce Compare October 17, 2024 03:59
Copy link
Collaborator

@dzbarsky dzbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the PR title?

@jbedard
Copy link
Member

jbedard commented Oct 17, 2024

@DavidZbarsky-at wdyt of the CI cache changes going along with the bazel upgrade?

I'm not super familiar with the GH CI but it seems like the ~ in env was not being expanded, and for some reason with bazel >= 7.2 the rules_js/~/.cache/xdg-cache directory suddenly has some BUILD files in it causing failures in just about every CI job.

@jbedard jbedard force-pushed the bump_to_latest_bazel branch from bf0a6ce to 937fabf Compare October 17, 2024 04:17
@jbedard jbedard changed the title chore: bump to Bazel 7.3.1 chore: upgrade bazel to v7.3.2 Oct 17, 2024
@jbedard jbedard force-pushed the bump_to_latest_bazel branch from 937fabf to 30daf89 Compare October 17, 2024 04:18
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@dzbarsky
Copy link
Collaborator

@DavidZbarsky-at wdyt of the CI cache changes going along with the bazel upgrade?

I'm not super familiar with the GH CI but it seems like the ~ in env was not being expanded, and for some reason with bazel >= 7.2 the rules_js/~/.cache/xdg-cache directory suddenly has some BUILD files in it causing failures in just about every CI job.

yeah I generally don't trust tools to expand ~ consistently and it seems fine to use the default locations

@jbedard jbedard force-pushed the bump_to_latest_bazel branch from 30daf89 to 4b69372 Compare October 17, 2024 15:41
@jbedard
Copy link
Member

jbedard commented Oct 17, 2024

Note the "Post Mount bazel caches" CI step is taking forever 🤔

@jbedard jbedard force-pushed the bump_to_latest_bazel branch from 4b69372 to 3d6c0bd Compare October 17, 2024 16:05
@jbedard jbedard merged commit 7d20158 into main Oct 17, 2024
105 of 109 checks passed
@jbedard jbedard deleted the bump_to_latest_bazel branch October 17, 2024 18:37
@gregmagolan
Copy link
Member Author

XDG_CACHE_HOME is also problematic for other reasons: bazel-contrib/bazel-lib#914 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants