build: only run e2e/runfiles on bazel6 when non-bzlmod

See bazel-contrib/rules_nodejs#3797
aspect-build · Oct 17, 2024 · 9611cbe · 9611cbe
1 parent 31bf0e3
commit 9611cbe
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -156,6 +156,12 @@ jobs:
                           major: 6
                       bzlmod: 0
                       folder: e2e/gyp_no_install_script
+                    # @bazel/runfiles seems broken with non-bzlmod + bazel7
+                    # https://github.com/bazel-contrib/rules_nodejs/issues/3797
+                    - bazel-version:
+                          major: 7
+                      bzlmod: 0
+                      folder: e2e/runfiles
                 include:
                     - bazel-version:
                           major: 7
@@ -185,6 +191,13 @@ jobs:
                       os: macos
                       config: local
                       folder: e2e/bzlmod
+                    # @bazel/runfiles seems broken with non-bzlmod + bazel7, so test with bazel6
+                    # https://github.com/bazel-contrib/rules_nodejs/issues/3797
+                    - bazel-version:
+                          major: 6
+                          version: 6.5.0
+                      bzlmod: 0
+                      folder: e2e/runfiles
 
         # Steps represent a sequence of tasks that will be executed as part of the job
         steps:

diff --git a/examples/runfiles/BUILD.bazel b/examples/runfiles/BUILD.bazel
@@ -11,6 +11,10 @@ js_test(
         ":node_modules/@bazel/runfiles",
     ],
     entry_point = "test.js",
+    target_compatible_with = select({
+        "@aspect_bazel_lib//lib:bzlmod": [],
+        "//conditions:default": ["@platforms//:incompatible"],
+    }),
 )
 
 # Path of file must start similar to `test_fixture.md` in order to regression-test a