fix: pnpm v9 version edge cases #1732

jbedard · 2024-05-15T05:53:35Z

More minor changes to the pnpm 9 lockfile data.

Changes are visible to end-users: no

Test plan

New test cases added
Manual testing; please provide instructions so we can reproduce:

…t-build#1566)

…ild#1567)

…slate_lock (aspect-build#1568)

…_lock (aspect-build#1569)

…datory (aspect-build#1571)

…ct-build#1572)

aspect-build#1573)

…om npm_translate_lock (aspect-build#1574)

…-build#1575)

aspect-build#1576)

…pstream instead (aspect-build#1578)

…vate:experimental_allow_unresolved_symlinks (aspect-build#1577)

chore: bump minimum bazel-lib version to 2.7.1 Fixes aspect-build#159

…end on a mininum bazel-lib 2.6.1 (aspect-build#1582)

…k js_run_binary (aspect-build#1581)

…ectory (aspect-build#1583)

…d#1584)

…js_filegroup rules and gather_files_from_js_providers + gather_runfiles helpers (aspect-build#1585)

…rnative in bazel-lib (aspect-build#1587)

…ng unused npm_linked_packages from JsInfo; rename load bearing npm_linked_package_files to npm_linked_packages (aspect-build#1588)

…t-build#1594)

…nchers (aspect-build#1586)

…enable_runfiles instead (aspect-build#1605)

…ild#1607)

… Aspect bazel-lib utils instead (aspect-build#1606)

…ild#1608)

…-build#1658)

…fos (aspect-build#1665)

…_js_register_toolchains (aspect-build#1667)

… to js_binary, js_test and js_run_binary

…ld#1701)

…build#1690)

…_lock(patches) (aspect-build#1694) Fix aspect-build#1427 Close aspect-build#1693 Close aspect-build#837

…uild#1714)

…s declarations, transitive_declarations, npm_package_store_deps and transitive_npm_linked_package_files (aspect-build#1715)

…build#1700)

Close aspect-build#1652

…#1731)

aspect-workflows · 2024-05-15T06:00:53Z

Test

⚠️ Buildkite build #3983 failed.

Failed tests (1)

//npm/private/test:write_npm_translate_lock_bzlmod_0_test [k8-fastbuild]                 533ms

💡 To reproduce the test failures, run

bazel test //npm/private/test:write_npm_translate_lock_bzlmod_0_test

Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 467ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 693ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 9s.

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 845ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 773ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 248ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 511ms.

Test

e2e/pnpm_lockfiles

4 test targets passed

Targets

//v54:lockfile [k8-fastbuild]                                                                           167ms
//v60:lockfile [k8-fastbuild]                                                                           58ms
//v61:lockfile [k8-fastbuild]                                                                           73ms
//v90:lockfile [k8-fastbuild]                                                                           274ms

Total test execution time was 572ms. 4 tests (50.0%) were fully cached saving 2s.

Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 451ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 393ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 187ms.

Buildifier Format

jbedard · 2024-05-17T18:11:48Z

replaced with #1735

gregmagolan added 30 commits May 14, 2024 00:46

refactor: remove unused src_directory from NpmPackageStoreInfo (aspec…

c63cc21

…t-build#1566)

refactor: default include_runfiles to False in npm_package (aspect-bu…

4842b78

…ild#1567)

refactor: remove unused warn_on_unqualified_tarball_url from npm_tran…

135eda1

…slate_lock (aspect-build#1568)

refactor: remote deprecated package_json attribute from npm_translate…

09f13d3

…_lock (aspect-build#1569)

refactor: removed deprecated //npm:npm_import.bzl (aspect-build#1570)

02e4f2c

refactor: make unresolved_symlinks_enabled attribute of js_binary man…

7eef9ca

…datory (aspect-build#1571)

refactor: remove deprecated run_lifecycle_hooks from npm_import (aspe…

e27291d

…ct-build#1572)

refactor: remove deprecated lifecycle_hooks_no_sandbox from npm_import (

21b203f

aspect-build#1573)

refactor: remove deprecated update_pnpm_lock_node_toolchain_prefix fr…

ea0bf4e

…om npm_translate_lock (aspect-build#1574)

refactor: rename directory attribute of NpmPackageInfo to src (aspect…

5e598b7

…-build#1575)

refactor: remove pnpm_version from npm_translate_lock bzlmod extension (

b17edea

aspect-build#1576)

refactor: remove vendored is_bazel_7_or_greater from bazel-lib; use u…

cbe3f69

…pstream instead (aspect-build#1578)

refactor: remove deprecated //js/private:enable_runfiles and //js/pri…

d23eb65

…vate:experimental_allow_unresolved_symlinks (aspect-build#1577)

refactor: set minimum aspect_bazel_lib to 2.7.1 (aspect-build#1580)

6b62fb2

chore: bump minimum bazel-lib version to 2.7.1 Fixes aspect-build#159

refactor: also register bazel-lib coreutils toolchain now that we dep…

46ca91d

…end on a mininum bazel-lib 2.6.1 (aspect-build#1582)

refactor: always set use_default_shell_env on generated lifecycle hoo…

2f39ef7

…k js_run_binary (aspect-build#1581)

refactor: use Aspect bazel-lib repo_utils.get_env_var to get HOME dir…

000f547

…ectory (aspect-build#1583)

refactor: use consistent_label_str from Aspect bazel-lib (aspect-buil…

7f40a0e

…d#1584)

refactor: add include_sources and include_transitive_declarations to …

b748bfb

…js_filegroup rules and gather_files_from_js_providers + gather_runfiles helpers (aspect-build#1585)

refactor: remove expand_template rule since we now have a better alte…

e63750b

…rnative in bazel-lib (aspect-build#1587)

refactor: remove unused NpmLinkedPackageInfo provider and correspondi…

a5a904c

…ng unused npm_linked_packages from JsInfo; rename load bearing npm_linked_package_files to npm_linked_packages (aspect-build#1588)

refactor: drop support for Bazel 5 (aspect-build#1589)

89a666d

perf: reduce size of npm_package_store transitive_files depset (aspec…

1463457

…t-build#1594)

fix: drop .sh extension from js_binary, merger and js_image_layer lau…

da7b74b

…nchers (aspect-build#1586)

refactor: set minimum rules_nodejs version to 6.1.0 (aspect-build#1579)

84be5f3

refactor: remove //js:enable_runfiles and use @aspect_bazel_lib//lib:…

7d007b5

…enable_runfiles instead (aspect-build#1605)

chore: drop TODOs earmarked for 2.0 that won't be done yet (aspect-bu…

52731cb

…ild#1607)

refactor: remove utils.home_directory and use get_home_directory from…

1ffbd2a

… Aspect bazel-lib utils instead (aspect-build#1606)

refactor: use utils struct from Aspect bazel-lib utils.bzl (aspect-bu…

d78401b

…ild#1608)

chore: run all e2e tests on CI (aspect-build#1609)

db95174

jbedard and others added 23 commits May 14, 2024 09:51

refactor: remove npm_translate_lock(use_starlark_yaml_parser) (aspect…

181e168

…-build#1658)

refactor: rename gather_files_from_js_info to gather_files_from_js_in…

aa5024c

…fos (aspect-build#1665)

chore: be explicit about node_version in all places we register rules…

0b1ce7b

…_js_register_toolchains (aspect-build#1667)

refactor: add include_sources and include_transitive_types attributes…

4628b4e

… to js_binary, js_test and js_run_binary

chore: cleanup WORKSPACE and MODULE.bazel files (aspect-build#1673)

0164e62

refactor: change default linked target name to 'pkg' (aspect-build#1684)

44e0c9e

refactor: default npm_package(publishable) to false (aspect-build#1683)

f9139ad

chore: fixup snapshot tests after rebase (aspect-build#1688)

92d7027

refactor: remove support for pnpm v6 (aspect-build#1696)

e7d0105

refactor: remove support for reloading lockfile on update (aspect-bui…

64ed71d

…ld#1701)

refactor: update js_binary executable path to {name}_/{name} (aspect-…

94f818b

…build#1690)

chore: add 1p linked deps to e2e/js_image_oci (aspect-build#1710)

05f5482

feat: support direct 1p links in js_image_layer (aspect-build#1711)

0140db1

fix: do not support mixing pnpm.patchedDependencies and npm_translate…

6dd0376

…_lock(patches) (aspect-build#1694) Fix aspect-build#1427 Close aspect-build#1693 Close aspect-build#837

feat: split js_image_layer into 5 layers (aspect-build#1712)

b57ffca

refactor: set minimum aspect_bazel_lib to 2.7.3

cba852d

feat: add generate_empty_layers attribute to js_image_layer (aspect-b…

6b12da4

…uild#1714)

feat: add backward compat handling for rules_js 1.x js_info parameter…

dcfa923

…s declarations, transitive_declarations, npm_package_store_deps and transitive_npm_linked_package_files (aspect-build#1715)

refactor: always read pnpm.patchedDependencies from lockfile (aspect-…

4f6a6d5

…build#1700)

feat: support pnpm.onlyBuiltDependencies (aspect-build#1723)

4db6bd0

feat: support pnpm lock v9 (aspect-build#1679)

3528874

Close aspect-build#1652

refactor: set bazel_compatibility for bzlmod to >=6.0.0 (aspect-build…

121ae28

…#1731)

fix: pnpm v9 version edge cases

f767cb1

jbedard requested a review from gregmagolan May 15, 2024 05:53

jbedard force-pushed the 2.x branch from c4ebc84 to 3fbc509 Compare May 16, 2024 18:00

jbedard marked this pull request as draft May 17, 2024 06:09

jbedard closed this May 17, 2024

jbedard deleted the pnpm-v9-npm-alias branch May 17, 2024 18:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: pnpm v9 version edge cases #1732

fix: pnpm v9 version edge cases #1732

jbedard commented May 15, 2024

aspect-workflows bot commented May 15, 2024 •

edited

Loading

jbedard commented May 17, 2024

fix: pnpm v9 version edge cases #1732

fix: pnpm v9 version edge cases #1732

Conversation

jbedard commented May 15, 2024

Changes are visible to end-users: no

Test plan

aspect-workflows bot commented May 15, 2024 • edited Loading

Test

Test

e2e/bzlmod

Test

e2e/gyp_no_install_script

Test

e2e/js_image_oci

Test

e2e/npm_link_package

Test

e2e/npm_link_package-esm

Test

e2e/npm_translate_lock

Test

e2e/npm_translate_lock_empty

Test

e2e/npm_translate_lock_multi

Test

e2e/npm_translate_lock_partial_clone

Test

e2e/npm_translate_lock_subdir_patch

Test

e2e/npm_translate_package_lock

Test

e2e/npm_translate_yarn_lock

Test

e2e/package_json_module

Test

e2e/pnpm_lockfiles

Test

e2e/pnpm_workspace

Test

e2e/pnpm_workspace_rerooted

Test

e2e/repo_mapping

Test

e2e/rules_foo

Test

e2e/vendored_node

Buildifier Format

jbedard commented May 17, 2024

aspect-workflows bot commented May 15, 2024 •

edited

Loading