-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: normalize pnpm lockfile data in parser #1735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3c3c43
to
a8f655f
Compare
d87cfc4
to
bd0d8ab
Compare
e54a9b5
to
4e17ddd
Compare
jbedard
commented
May 17, 2024
bef5292
to
cce6439
Compare
b4e98df
to
28e8e98
Compare
6f22fbd
to
683a860
Compare
gregmagolan
reviewed
May 21, 2024
gregmagolan
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the data is standardized to a format for rules_js at parse time instead of elsewhere throughout the code.
Today the lockfile parsing normalizes to a version similar to pnpm lock v5, then
_gather_package_info
normalizes that a bit to a more rules_js specific format. The idea of this PR is to directly convert to that rules_js format as part of parsing, instead ofpnpm vX => pnpm v5 => rules_js
(where X = 5,6,9) we will havepnpm vX => rules_js
and ideally have less code...Changes are visible to end-users: no
Test plan