Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drop .sh extension from js_binary, merger and js_image_layer launchers #1586

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: drop .sh extension from js_binary, merger and js_image_layer launchers #1586

merged 1 commit into from
Apr 3, 2024

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Apr 3, 2024 •
edited
Loading

Fixes #845

@gregmagolan gregmagolan requested review from alexeagle and jbedard April 3, 2024 02:16
@gregmagolan gregmagolan changed the title refactor: drop .sh extension from js_binary, merger and js_image_layer launchers fix: drop .sh extension from js_binary, merger and js_image_layer launchers Apr 3, 2024
alexeagle
alexeagle approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might hit some roadbumps with this, should find out as we roll a release candidate to clients

@gregmagolan
Copy link
Member Author

I think we might hit some roadbumps with this, should find out as we roll a release candidate to clients

Yeah, the require('foo') where there is both a foo.js and foo in the directory prefers foo oddly. I doubt that many users will hit that case but you never know.

@gregmagolan gregmagolan merged commit 3f10f3d into 2.x Apr 3, 2024
2 checks passed
@gregmagolan gregmagolan deleted the rjs2_21 branch April 3, 2024 20:58
gregmagolan added a commit that referenced this pull request Apr 4, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
b407431 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request Apr 6, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
e193042 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request Apr 7, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
fb47e4a 
…nchers (#1586)
jbedard pushed a commit that referenced this pull request Apr 9, 2024
@gregmagolan @jbedard
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
8e6687b 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request Apr 9, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
f09ca7f 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request Apr 13, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
162cc88 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request Apr 13, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
25f9015 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request Apr 15, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
2c75c92 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request Apr 19, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
69132b1 
…nchers (#1586)
jbedard pushed a commit that referenced this pull request Apr 19, 2024
@gregmagolan @jbedard
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
6bb0e8f 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request Apr 20, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
741dee5 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request Apr 21, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
c31d47e 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request Apr 21, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
066f61b 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request Apr 22, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
3646300 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request Apr 23, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
68be5d9 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request Apr 24, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
39156e1 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request Apr 26, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
37de178 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request Apr 28, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
ab04132 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request Apr 28, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
9c80bb0 
…nchers (#1586)
@gregmagolan gregmagolan mentioned this pull request Apr 29, 2024
Closed
21 tasks
gregmagolan added a commit that referenced this pull request Apr 29, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
9bcfa1c 
…nchers (#1586)
@gregmagolan gregmagolan mentioned this pull request May 2, 2024
Merged
gregmagolan added a commit that referenced this pull request May 6, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
35d150e 
…nchers (#1586)
jbedard pushed a commit that referenced this pull request May 6, 2024
@gregmagolan @jbedard
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
d02c325 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
7319614 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
3810a77 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
afaecae 
…nchers (#1586)
jbedard pushed a commit that referenced this pull request May 8, 2024
@gregmagolan @jbedard
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
93745da 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request May 10, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
7e0ce9d 
…nchers (#1586)
@gregmagolan gregmagolan mentioned this pull request May 10, 2024
Merged
gregmagolan added a commit that referenced this pull request May 13, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
7d61d40 
…nchers (#1586)
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 14, 2024
@gregmagolan @jbedard
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
da7b74b 
…nchers (aspect-build#1586)
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 16, 2024
@gregmagolan @jbedard
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
832988c 
…nchers (aspect-build#1586)
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
4bd2514 
…nchers (#1586)
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
fix: drop .sh extension from js_binary, merger and js_image_layer lau…
8776cac 
…nchers (#1586)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@jbedard jbedard Awaiting requested review from jbedard

Assignees
No one assigned
Labels
None yet
Projects
Open Source
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregmagolan @alexeagle