rules_js is failing with error "while parsing configuration settings: unknown option: 'experimental_allow_unresolved_symlinks' " with Bazel@HEAD in CI #1102
Assignees
Labels
bug
Something isn't working
Comments
This was referenced Jun 5, 2023
jbedard
added a commit
to jbedard/rules_js
that referenced
this issue
Jun 5, 2023
jbedard
added a commit
to jbedard/rules_js
that referenced
this issue
Jun 6, 2023
jbedard
added a commit
to jbedard/rules_js
that referenced
this issue
Jun 6, 2023
jbedard
added a commit
to jbedard/rules_js
that referenced
this issue
Jun 6, 2023
jbedard
added a commit
to jbedard/rules_js
that referenced
this issue
Jun 6, 2023
jbedard
added a commit
to jbedard/rules_js
that referenced
this issue
Jun 6, 2023
jbedard
added a commit
to jbedard/rules_js
that referenced
this issue
Jun 6, 2023
jbedard
added a commit
to jbedard/rules_js
that referenced
this issue
Jun 6, 2023
|
Hi @jbedard, Can you please share any significant update on this issue. Thanks! |
|
/cc @gregmagolan @alexeagle This is blocking other projects from getting back to green in Bazel's downstream pipeline. |
|
Sorry I haven't had a chance to work on this recently and don't recall how much progress I made. It's this blocking you atm? Can you try the commit referencing the issue? (I don't recall the status of it and won't have a chance to look now, so apologies if it's not in a state ready to try...) |
|
I can pick this one up @jbedard |
|
@meteorcloudy I think the https://github.com/bazel-contrib/bazel_features repo might be the right place to generally adapt starlark rules that want to sense the value of this flag. See bazel-contrib/bazel_features#14. If that lands, then #1177 is the fix for this I believe |
alexeagle
added a commit
to bazel-contrib/bazel_features
that referenced
this issue
Jul 26, 2023
Allows a principled solution for rules like rules_js that need to have starlark logic conditional on the value, without a breaking change in Bazel 7 as the flag has been renamed. Unblocks aspect-build/rules_js#1102
alexeagle
added a commit
to bazel-contrib/bazel_features
that referenced
this issue
Jul 26, 2023
Allows a principled solution for rules like rules_js that need to have starlark logic conditional on the value, without a breaking change in Bazel 7 as the flag has been renamed. Unblocks aspect-build/rules_js#1102
alexeagle
added a commit
to bazel-contrib/bazel_features
that referenced
this issue
Jul 27, 2023
Allows a principled solution for rules like rules_js that need to have starlark logic conditional on the value, without a breaking change in Bazel 7 as the flag has been renamed. Unblocks aspect-build/rules_js#1102
alexeagle
added a commit
to bazel-contrib/bazel_features
that referenced
this issue
Jul 27, 2023
Allows a principled solution for rules like rules_js that need to have starlark logic conditional on the value, without a breaking change in Bazel 7 as the flag has been renamed. Unblocks aspect-build/rules_js#1102
alexeagle
added a commit
to bazel-contrib/bazel_features
that referenced
this issue
Jul 27, 2023
Allows a principled solution for rules like rules_js that need to have starlark logic conditional on the value, without a breaking change in Bazel 7 as the flag has been renamed. Unblocks aspect-build/rules_js#1102 Alternative to #14
alexeagle
added a commit
to bazel-contrib/bazel_features
that referenced
this issue
Jul 27, 2023
Allows a principled solution for rules like rules_js that need to have starlark logic conditional on the value, without a breaking change in Bazel 7 as the flag has been renamed. Unblocks aspect-build/rules_js#1102 Alternative to #14
alexeagle
added a commit
that referenced
this issue
Jul 27, 2023
alexeagle
added a commit
to bazel-contrib/bazel_features
that referenced
this issue
Jul 27, 2023
* feat: expose a flag name for allow_unresolved_symlinks Allows a principled solution for rules like rules_js that need to have starlark logic conditional on the value, without a breaking change in Bazel 7 as the flag has been renamed. Unblocks aspect-build/rules_js#1102 Alternative to #14 * code review comments * fix: be precise about which 7.0 release changes the flag name
alexeagle
added a commit
that referenced
this issue
Jul 27, 2023
* fix: allow for Bazel 7 flag rename fixes #1102 * chore: improve docs * docs: ensure our WORKSPACE snippet mentions bazel_features init code * fix: don't double-register bazel_features * move bazel_features_deps where needed
ngiloq6
added a commit
to ngiloq6/bazel_features
that referenced
this issue
Aug 17, 2024
* feat: expose a flag name for allow_unresolved_symlinks Allows a principled solution for rules like rules_js that need to have starlark logic conditional on the value, without a breaking change in Bazel 7 as the flag has been renamed. Unblocks aspect-build/rules_js#1102 Alternative to #14 * code review comments * fix: be precise about which 7.0 release changes the flag name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rules_js is breaking with Bazel@HEAD and some projects depending on it.
https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3068#018879de-8112-4f1d-a1bd-c19508b89002
https://github.com/aspect-build/rules_js/blob/2f64180ba84693d0bfb975b44b520e95ecb80adb/js/private/BUILD.bazel#L2
Error logs:
Reference : bazelbuild/bazel@215f698#commitcomment-116145231
CC @alexeagle @mai93
The text was updated successfully, but these errors were encountered: