declare_symlink: remove experimental warning

Users have started using this feature since Bazel 6.0.0 without much complains. Let's graduate the experimental flag and doc to stable Leave the flag around for user to disable the behavior if desired. Closes #18313. PiperOrigin-RevId: 536994696 Change-Id: I2dbc09e591bd83f9c35bf2553a0994a685195a27
bazelbuild · Jun 1, 2023 · 215f698 · 215f698 · meteorcloudy · Jun 2, 2023
1 parent c997543
commit 215f698
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 11 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/CoreOptions.java b/src/main/java/com/google/devtools/build/lib/analysis/config/CoreOptions.java
@@ -697,7 +697,8 @@ public OutputDirectoryNamingSchemeConverter() {
   public Label autoCpuEnvironmentGroup;
 
   @Option(
-      name = "experimental_allow_unresolved_symlinks",
+      name = "allow_unresolved_symlinks",
+      oldName = "experimental_allow_unresolved_symlinks",
       defaultValue = "true",
       documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
       effectTags = {

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkActionFactory.java b/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkActionFactory.java
@@ -221,7 +221,7 @@ public Artifact declareSymlink(String filename, Object sibling) throws EvalExcep
     if (!ruleContext.getConfiguration().allowUnresolvedSymlinks()) {
       throw Starlark.errorf(
           "actions.declare_symlink() is not allowed; "
-              + "use the --experimental_allow_unresolved_symlinks command line option");
+              + "use the --allow_unresolved_symlinks command line option");
     }
 
     Artifact result;

diff --git a/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/StarlarkActionFactoryApi.java b/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/StarlarkActionFactoryApi.java
@@ -134,13 +134,10 @@ public interface StarlarkActionFactoryApi extends StarlarkValue {
   @StarlarkMethod(
       name = "declare_symlink",
       doc =
-          "<p>This parameter is experimental and may change at any "
-              + "time. It may be disabled by "
-              + "setting <code>--noexperimental_allow_unresolved_symlinks</code></p> <p>Declares "
-              + "that the rule or aspect creates a symlink with the given name in the current "
-              + "package. You must create an action that generates this symlink. Bazel will never "
-              + "dereference this symlink and will transfer it verbatim to sandboxes or remote "
-              + "executors. Symlinks inside tree artifacts are not currently supported.",
+          "Declares that the rule or aspect creates a symlink with the given name in the current"
+              + " package. You must create an action that generates this symlink. Bazel will never"
+              + " dereference this symlink and will transfer it verbatim to sandboxes or remote"
+              + " executors. Symlinks inside tree artifacts are not currently supported.",
       parameters = {
         @Param(
             name = "filename",

diff --git a/src/test/shell/bazel/bazel_symlink_test.sh b/src/test/shell/bazel/bazel_symlink_test.sh
@@ -137,9 +137,9 @@ load("//symlink:symlink.bzl", "dangling_symlink")
 dangling_symlink(name="a", link_target="non/existent")
 EOF
 
-  bazel build --noexperimental_allow_unresolved_symlinks //a:a >& $TEST_log \
+  bazel build --noallow_unresolved_symlinks //a:a >& $TEST_log \
     && fail "build succeeded, but should have failed"
-  expect_log 'declare_symlink() is not allowed; use the --experimental_allow_unresolved_symlinks'
+  expect_log 'declare_symlink() is not allowed; use the --allow_unresolved_symlinks'
 }
 
 function test_inmemory_cache_symlinks() {