-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent: add initial background script #952
Conversation
What would be the best approach here? Update: designs expect a token too, which token should be displayed here? Update 2: same with Source/Recipient it expects one address |
The best option might be to use the DataView's "entry expansion" to show multiple transactions. If we don't want to do that now though, we could just say "multiple tokens" and "multiple" for source / recipient for the row. |
How about this:
|
13a8ebc
to
87f98fe
Compare
78cf1aa
to
b988b3b
Compare
* Updated Tokens and Finance screenshots to 0.8 * Optimize new assets * Added voting screenshots * Optimize voting assets
* Small typo fix in Voting * Changed vote action copy
* Agent: add boilerplate based on Finance * Agent: update manifest to point to UI and script files * Agent: add missing rxjs dependency * Agent: update web3 dependencies to 1.x versions * Reducer: update transactions reducer * FrameModal: remove duplicate close button * Transfer: update rendering according to new mocked data * Update mock data * Transfer: improve spacing on inner entry * Update deps versions * Remove unused components & assets * Reducer: update metadata on transactions about incoming & outcoming token transfers * Update mocked data * useFilteredTransfers: add independent hook * Update to use new useFilteredTransfers hook * Remove unused asset * useDownloadData: add hook to abstract logic * Transfers: move download logic to hook * Set format date format * Transfers: remove unused imports and remove above & below * useFilteredTransfers: remove unused imports * Transfers: remove unused import * useDownloadData: update imports * Transfers: simplify component and remoe unused function * InstallFrame: no need to check prop types if there are no props * FrameModal: update dependencies and add href for Frame info * FrameSvg: fix lint error * FrameAndAgentSvg: fix lint error * App: remove useViewport and unused imports * Remove unused file * Agent: update dependencies * Agent: add token ABIs * chore: add build task in main agent repo * Changed install Frame copy * Add agent svg * AgentSvg: add component to access svg * ComingSoon: add component * App: render coming soon instead of balances & transfers * InstallFrame: hide info box if Frame is running * ComingSoon: update copy Co-Authored-By: Jorge Izquierdo <jorge@aragon.one> * ComingSoon: update copy Co-Authored-By: Jorge Izquierdo <jorge@aragon.one> * ComingSoon: update copy Co-Authored-By: Jorge Izquierdo <jorge@aragon.one>
* Small typo fix in Voting * Changed vote action copy * Change voting action copy
* Small typo fix in Voting * Changed vote action copy * Change voting action copy * Fixes suggestions
* Latest icons * svgoify all the things
b988b3b
to
2d2a365
Compare
// TODO: add call to fetch current agent app's address once available in aragon.js | ||
// and add it to settings | ||
app | ||
.call('initialized') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.call('initialized') | |
.call('hasInitialized') |
.then(() => initialize()) | ||
.catch(_ => { | ||
throw new Error( | ||
'Could not start background script execution due to the contract not being connected to a network:' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Could not start background script execution due to the contract not being connected to a network:' | |
'Could not start background script execution due to the contract not being connected to a network' |
Closing for #1082 |
Not yet tested, and has a few todos to complete (pending more work on aragon.js).
Passes to the frontend data in the form of:
The
null
possibility for thefrom
andto
fields of thetokenTransfers
is intended to help front-end filtering based on incoming / outgoing transactions, but can be changed to suit the frontend as necessary.Note that
tokenTransfers
is an array that can hold multiple token transactions (a single transaction that executes a contract can include many internal token transfers). For flexibility / simplicity, it currently does not do any grouping on the transfers, although we may want to do so in the frontend (sum all amounts for the same token) to meet the current designs.There are a few edge cases in the current reducing that will require more complex detection to provide good UX. One example is a single transaction invoking multiple Agent executions that each transfer tokens. Another is directly receiving ETH onto the Agent's proxy from a contract interaction, as it's difficult to correlate receiving ETH with a contract execution based solely on the events in the general case. In the current state, these cases will be presented slightly confusingly to users (most likely symptom is duplicate / multiple transaction entries for a single data).
TODO:
ProxyDeposit
is not currently automatically decoded)