Agent: read-only UI #1082

Evalir · 2020-02-14T14:53:16Z

This PR gives the Agent App a read-only UI for balances and transactions. Further improvements will be made in the future with this initial implementation.

Todos:

Refactor all heavily used components to functional (done)
Workout last background script issues and test heavily on agent-based DAOs.
- Remove bugs on Multiple transactions: No token transfers are being found.
- Make all tokens display correctly (price, image)
- UI issues with sync indicator making the page bigger than it should be
Fix transfer filtering
Add custom badge functionality
Remove frontend inconsistencies with the design.
Flesh out last edge cases when dealing with multiple transactions or call scripts.

…sfers

welcome · 2020-02-14T14:53:18Z

Thanks for opening this pull request! Someone will review it soon 🔍

…ify badges, cosmetic enhancements

…esign QA

They got included in the merge commit 0fe37e3, even though the merge commit indicates a clean merge (no changes at all).

sohkai

Haven't looked at a few of the components, but leaving a few notes here first :).

Overall looking really good, let's save some of the web3-specific stuff that I commented on for the end!

apps/agent/app/package.json

apps/agent/app/src/lib/token-utils.js

apps/finance/app/src/components/EmptyFilteredTransfers.js

apps/agent/app/src/script.js

apps/agent/app/src/lib/token-utils.js

apps/agent/app/src/lib/utils.js

sohkai

A couple more notes and suggestions on the components themselves and most should be pretty quick to address!

I noticed we could do another round of clean up in the agent/app folder itself; let's:

Run the linter
Remove any unused components and assets

apps/agent/app/src/components/Transactions.js

apps/agent/app/src/components/useDownloadData.js

apps/agent/app/src/components/useFilteredTransactions.js

…apps into agent-readonly-ui

apps/agent/app/src/script.js

apps/agent/app/src/abi/agent-execute-event.json

sohkai · 2020-03-10T19:33:51Z

apps/agent/app/src/components/useFilteredTransactions.js

@@ -47,6 +50,8 @@ function useFilteredTransactions({ transactions, tokens }) {

        // Exclude by date range
        if (
+          // We're not checking for and end date because we will always


Finance checks both the start and end dates in its filtering implementation, but a small change we could make is to program defensively (and against any "app assumptions") in both of these apps by using something like:

!selectedDateRange.start && isAfter(new Date(date), selectedDateRange.start) && !selectedDateRange.end && isAfter(new Date(date), selectedDateRange.end)

apps/agent/app/src/components/Transactions.js

apps/agent/app/src/components/useDownloadData.js

apps/agent/app/src/script.js

…hanges

sohkai · 2020-03-11T16:57:23Z

apps/agent/app/src/script.js

@@ -278,20 +289,9 @@ async function newExecution(state, event, settings) {
    })
    .filter(Boolean)

-  if (ethValue && ethValue !== '0') {
-    tokenTransfers.push({


Ah actually, I just realized a better way to do this is with [].unshift()

apps/agent/app/src/script.js

sohkai

Just a few last comments but looks good to merge otherwise!

Let's just make sure to update the current app's text before merging this one :).

…-utils

* Agent: add initial background script * Agent: update script to pass transaction hashes * Agent: rename `address` to `token` for token address inside tokenTransfers * Agent: handle ProxyDeposit events * Integrate darkmode, fix script initialization, heavy component refactor * Add correct transaction types * Temporarily correct transfer bugs to repair build * Fix dataview design debt * Working multiple token transfers * Update aragon ui, use tokenIconUrl() for tokens * Fix token icons * Add custom badge functionality * Fix token display, add colors to entry expansion * Fix double scroll UI bug :-) * Fix mobile network bug, add initial filtering * Demo-ready * Find target contract interaction if there are no token transfers, modify badges, cosmetic enhancements * Minor cosmetic refactor * Refactor script, memoize transaction list * Cosmetic code cleanup * Revert empty results memoization * Refactor transactions, add proper mobile view and other points from design QA * Code cleanup * ESLint: add exhaustive deps * ESLint fixes * Optimize SVG * Add code review suggestions * Correct format error, remove console logs * Remove lodash throttle, remove firefox translate3d fix * Remove unused prop * Use ROUNDING_AMOUNT * Fix addresses not resolving on CSV * Fix badges taking column width * Non-breaking spaces * Create CSV data on demand * Date formats * Use DataView empty state * Code style * CSV files: escape double quotes in content * CSV: add type * Remove TRANSACTION_TYPES_STRING * Fix aragonUI update breaking changes * Manually checkout the other apps They got included in the merge commit 0fe37e3, even though the merge commit indicates a clean merge (no changes at all). * Manually checkout future-apps * More cleanup after the manual checkout * Remove unused component * Apply most code review suggestions * Change 'marshal' to 'marshalTransactionDetails' * Remove agent ABIs, fix entity logic for badges, minor cosmetic code changes * Add agent app address and transaction hash to file * use event target to get the target contract * Remove console log and unused findTargetFromReceipt function in token-utils * Update manifest.json and add screenshots * Agent: Fix test color on dataview expansion Co-authored-by: Brett Sun <qisheng.brett.sun@gmail.com> Co-authored-by: Pierre Bertet <hello@pierre.world>

sohkai and others added 5 commits September 10, 2019 19:27

Agent: add initial background script

e5fc23a

Agent: update script to pass transaction hashes

10c5cc6

Agent: rename address to token for token address inside tokenTran…

c6e2bc2

…sfers

Agent: handle ProxyDeposit events

2d2a365

Integrate darkmode, fix script initialization, heavy component refactor

b674ea3

probot-autolabeler bot added app: agent component: frontend labels Feb 14, 2020

Evalir added 13 commits February 17, 2020 14:43

Add correct transaction types

dc08652

Temporarily correct transfer bugs to repair build

d325f8a

Fix dataview design debt

c42f205

Working multiple token transfers

2b0b4a5

Update aragon ui, use tokenIconUrl() for tokens

680d559

Fix token icons

e06595f

Add custom badge functionality

1085ae1

Fix token display, add colors to entry expansion

bd5bbc8

Fix double scroll UI bug :-)

8d1d283

Fix mobile network bug, add initial filtering

5b64d49

Demo-ready

4b4ed03

Find target contract interaction if there are no token transfers, mod…

65a5a21

…ify badges, cosmetic enhancements

Minor cosmetic refactor

02427d1

Evalir marked this pull request as ready for review February 20, 2020 12:28

auto-assign bot requested review from bpierre and sohkai February 20, 2020 12:28

Evalir and others added 6 commits February 20, 2020 10:48

Refactor script, memoize transaction list

e0c7359

Cosmetic code cleanup

29e82d6

Revert empty results memoization

ba4f435

Refactor transactions, add proper mobile view and other points from d…

e0ea6cb

…esign QA

Code cleanup

8978d65

ESLint: add exhaustive deps

c4b3e7d

bpierre added 3 commits March 6, 2020 09:43

Manually checkout the other apps

9950bcf

They got included in the merge commit 0fe37e3, even though the merge commit indicates a clean merge (no changes at all).

Manually checkout future-apps

956e538

More cleanup after the manual checkout

e8d2acc

sohkai reviewed Mar 6, 2020

View reviewed changes

sohkai reviewed Mar 7, 2020

View reviewed changes

Evalir mentioned this pull request Mar 7, 2020

Finance: update script.js to include "token helpers" section #1091

Closed

bpierre and others added 3 commits March 7, 2020 15:03

Remove unused component

38d796d

Apply most code review suggestions

74cf959

Merge branch 'agent-readonly-ui' of https://github.com/aragon/aragon-…

0a93f26

…apps into agent-readonly-ui

sohkai reviewed Mar 10, 2020

View reviewed changes

apps/agent/app/src/components/useDownloadData.js Outdated Show resolved Hide resolved

sohkai reviewed Mar 10, 2020

View reviewed changes

apps/agent/app/src/script.js Outdated Show resolved Hide resolved

sohkai reviewed Mar 10, 2020

View reviewed changes

apps/agent/app/src/script.js Outdated Show resolved Hide resolved

Change 'marshal' to 'marshalTransactionDetails'

e734e9c

sohkai mentioned this pull request Mar 11, 2020

Agent: add initial background script #952

Closed

5 tasks

Evalir added 3 commits March 11, 2020 14:10

Remove agent ABIs, fix entity logic for badges, minor cosmetic code c…

8938ace

…hanges

Add agent app address and transaction hash to file

160a8ac

use event target to get the target contract

09b7807

sohkai reviewed Mar 11, 2020

View reviewed changes

apps/agent/app/src/script.js Outdated Show resolved Hide resolved

sohkai reviewed Mar 11, 2020

View reviewed changes

apps/agent/app/src/script.js Outdated Show resolved Hide resolved

sohkai approved these changes Mar 11, 2020

View reviewed changes

Evalir added 5 commits March 11, 2020 17:54

Remove console log and unused findTargetFromReceipt function in token…

e3adf63

…-utils

Merge branch 'master' into agent-readonly-ui

ca89180

Merge branch 'master' into agent-readonly-ui

2b0a618

Update manifest.json and add screenshots

6f2e235

Agent: Fix test color on dataview expansion

727f62f

Evalir merged commit a15d86e into master Mar 12, 2020

Evalir deleted the agent-readonly-ui branch March 12, 2020 00:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Agent: read-only UI #1082

Agent: read-only UI #1082

Evalir commented Feb 14, 2020 •

edited

Loading

welcome bot commented Feb 14, 2020

sohkai left a comment

sohkai left a comment •

edited by Evalir

Loading

sohkai Mar 10, 2020

sohkai Mar 11, 2020

sohkai left a comment

Agent: read-only UI #1082

Agent: read-only UI #1082

Conversation

Evalir commented Feb 14, 2020 • edited Loading

welcome bot commented Feb 14, 2020

sohkai left a comment

Choose a reason for hiding this comment

sohkai left a comment • edited by Evalir Loading

Choose a reason for hiding this comment

sohkai Mar 10, 2020

Choose a reason for hiding this comment

sohkai Mar 11, 2020

Choose a reason for hiding this comment

sohkai left a comment

Choose a reason for hiding this comment

Evalir commented Feb 14, 2020 •

edited

Loading

sohkai left a comment •

edited by Evalir

Loading